feat(kq): add batch push methods for Kafka producer #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Updated On: 2025-09-13 07:25:43 UTC
This PR adds batch push functionality to the Kafka producer in the
kq
package, introducing two new methods:BatchPush
andBatchPushWithKeys
. The changes enhance the existingPusher
struct with efficient bulk messaging capabilities.The implementation includes:
KeyValue
struct to represent key-value pairs for batch operationsBatchPush(ctx, msgs []string)
method that automatically generates timestamp-based keys for a slice of messagesBatchPushWithKeys(ctx, keyValues []KeyValue)
method that accepts explicit key-value pairsThe batch methods fit well into the existing architecture by reusing the established executor pattern and maintaining the same error handling and tracing mechanisms used by single-message methods like
Push
andPushWithKey
. This allows users to leverage Kafka's native batch write capabilities for improved throughput while preserving the same behavioral patterns.Comprehensive test coverage was added for both new methods, including normal operations, empty input handling, and error propagation scenarios.
Confidence score: 4/5