smoke test #634
smoke test #634
Conversation
|
D'oh! I forgot that
|
| - yarn | ||
| - pnpm | ||
| steps: | ||
| - uses: actions/setup-node@v4 |
There was a problem hiding this comment.
This can include multiple versions such as 10, 12, 18, 22 to ensure compatibility across different versions.
There was a problem hiding this comment.
You're absolutely right and I'd like to get there before this is merged. As you can see from my embarrassing commit history, I'm not quite there yet...
| npm install "git+${{ github.repositoryUrl }}#${{ github.ref }}" | ||
| env: | ||
| NPM_CONFIG_LOGLEVEL: verbose | ||
|
|
There was a problem hiding this comment.
It would be great to run a simple example where zeromq is imported. This will ensure the runtime compatibility via the smoke test for different Nodejs versions.
There was a problem hiding this comment.
I was thinking of possibly co-opting https://github.com/zeromq/zeromq.js/blob/ea5f35ceef48a9847562d53f839b3ffb74956711/examples/package.json
| steps: | ||
| - uses: actions/setup-node@v4 | ||
| - run: | | ||
| npm init --init-module testproject -y |
There was a problem hiding this comment.
You can use this template package and add an example test to it
https://github.com/zeromq/zeromq.js/tree/master/test/typings-compatibility/template
aminya
force-pushed
the
magnetic-manatee
branch
from
26c2cd2
to
188724d
Compare
Install this package as a dependency in a clean project