Skip to content

refactor: add missing useCallback import and explicit return #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerox80 merged 1 commit into from
Nov 11, 2025
Merged

refactor: add missing useCallback import and explicit return #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useMemo } from 'react'
import { useCallback, useMemo } from 'react'
import { useLocation, useNavigate } from 'react-router-dom'
import { Terminal, Heart } from 'lucide-react'

Check warning on line 3 in src/components/Footer.jsx

View workflow job for this annotation

GitHub Actions / frontend-test 

'Terminal' is defined but never used
import { useContent } from '../context/ContentContext'
import { navigateContentTarget } from '../utils/contentNavigation'
import { getIconComponent } from '../utils/iconMap'
Expand Down Expand Up @@ -243,7 +243,7 @@
quickLinks.map((link, index) => {
const href = link.href || '#'
const isExternal = typeof href === 'string' && (href.startsWith('http://') || href.startsWith('https://'))
const isSpecialProtocol = typeof href === 'string' && (href.startsWith('mailto:') || href.startsWith('tel:'))

Check warning on line 246 in src/components/Footer.jsx

View workflow job for this annotation

GitHub Actions / frontend-test 

'isSpecialProtocol' is assigned a value but never used
return (
<li key={link.label || link.target?.value || `quick-${index}`}>
<a
Expand Down
1 change: 1 addition & 0 deletions src/components/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
const { isAuthenticated } = useAuth()
const { getSection, navigation } = useContent()
const headerContent = getSection('header') ?? {}
const contentNavItems = Array.isArray(headerContent.navItems) ? headerContent.navItems : []

Check warning on line 24 in src/components/Header.jsx

View workflow job for this annotation

GitHub Actions / frontend-test 

The 'contentNavItems' conditional could make the dependencies of useMemo Hook (at line 46) change on every render. Move it inside the useMemo callback. Alternatively, wrap the initialization of 'contentNavItems' in its own useMemo() Hook
const BrandIcon = getIconComponent(headerContent?.brand?.icon, 'Terminal')
const ctaContent = headerContent?.cta ?? {}
const CTAIcon = getIconComponent(ctaContent.icon, 'Lock')
Expand Down Expand Up @@ -80,6 +80,7 @@
return
}
scrollToSection(sectionId)
return
}
}
const getNavHref = (item) => {
Expand Down
Loading