Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gère le cas où les résultats de la recherche ne contiennent pas de highlight #6679

Merged

Conversation

philippemilink
Copy link
Member

Problème rapporté par Sentry.

Contrôle qualité

  • Se fier au test et vérifier que la CI passe

ou

  • indexer les contenus avec make index-all et faire une recherche avec le terme -c. Ça doit afficher des résultats et ne pas générer d'erreur.

Copy link

sentry-io bot commented Oct 30, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: zds/search/views.py

Function Unhandled Issue
get_queryset IndexError: list index out of range /rechercher/
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

sentry-io bot commented Oct 30, 2024

Sentry Issue: ZDS-SITE-TW

@coveralls
Copy link

coveralls commented Oct 30, 2024

Coverage Status

coverage: 89.205%. remained the same
when pulling bbd507b on philippemilink:search-results-without-highlights
into f94bfd5 on zestedesavoir:dev.

@Situphen Situphen enabled auto-merge (rebase) October 30, 2024 23:20
@Situphen Situphen merged commit f183502 into zestedesavoir:dev Oct 30, 2024
7 checks passed
@philippemilink philippemilink deleted the search-results-without-highlights branch October 31, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Fusionnée
Development

Successfully merging this pull request may close these issues.

3 participants