This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Open
Conversation
The rationale is that if the user already has a `String`, using `ToString` will unnecessarily clone the `String` instead of assigning it directly.
Collaborator
|
Unfortunately, doing so would lose the ability to use any type that e.g. implements |
Author
|
|
zesterer
force-pushed
the
main
branch
2 times, most recently
from
2f36bc2 to
4b3807c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale is that if the user already has a
String, usingToStringwill unnecessarily clone theStringinstead of assigning itdirectly.
If you want, this can be done without a breaking change (i.e. keeping existing methods and adding new ones to support setting a string directly), but I'd argue that adds too much complexity to the API.