This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Removing magic numbers from color generator#34
Draft
TornaxO7 wants to merge 2 commits intozesterer:mainfrom
Draft
Removing magic numbers from color generator#34TornaxO7 wants to merge 2 commits intozesterer:mainfrom
TornaxO7 wants to merge 2 commits intozesterer:mainfrom
Conversation
zesterer
force-pushed
the
main
branch
2 times, most recently
from
2f36bc2 to
4b3807c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to change the constant numbers with constant variable names to make it easier to understand those constant numbers in the color generator. But I don't fully understand what your calculations are doing here:
Could you please explain them a bit and do you agree to move those constants to variables/(named) constants?