Cypress: Setup Fixture Seeding - Content List #3915
Conversation
geodem127
changed the base branch from
dev
to
test/seed-data-content-actions
geodem127
force-pushed
the
test/seed-data-content-actions
branch
3 times, most recently
from
8ada555 to
e28b7eb
Compare
geodem127
force-pushed
the
test/seed-data-content-actions
branch
from
e28b7eb to
d74d0b5
Compare
geodem127
force-pushed
the
test/seed-data-content-list
branch
2 times, most recently
from
17a6716 to
0851b8d
Compare
geodem127
force-pushed
the
test/seed-data-content-actions
branch
2 times, most recently
from
7f7a907 to
b184802
Compare
geodem127
force-pushed
the
test/seed-data-content-list
branch
2 times, most recently
from
77cb1b8 to
dd1fd0c
Compare
cypress/e2e/content/list.spec.js
Outdated
| cy.getBySelector("MultiPageTableSearchField").type("turkey"); | ||
| cy.get(".MuiDataGrid-cell").contains("Turkey Run"); | ||
| cy.getBySelector("MultiPageTableSearchField").type("{selectAll}{del}"); | ||
| it("Filters list items based on search term", function () { |
There was a problem hiding this comment.
Why was this changed from an arrow function to a traditional function declaration? I would prefer we keep things consistent unless this change is really necessary.
There was a problem hiding this comment.
In Cypress, variables stored using cy.wrap need to be accessed via this, which requires using a function() declaration. Since I used a different approach, I’ll be reverting it back to the original declaration.
cypress/e2e/content/list.spec.js
Outdated
| }); | ||
|
|
||
| it("Sorts list items", () => { | ||
| it("Sorts list items", function () { |
There was a problem hiding this comment.
Same comment here regarding the function declaration.
cypress/e2e/content/list.spec.js
Outdated
|
|
||
| cy.get(".MuiDataGrid-cell[data-colindex='2']") | ||
| .should("exist") | ||
| .contains(contentItems[4].data.text, { matchCase: false }); |
There was a problem hiding this comment.
Why is matchCase being set to false here? I would assume we would want to make an exact match to make sure the UI is behaving correctly
| const { formatPathPart } = require("../../../src/utility/formatPathPart"); | ||
| const { formatName } = require("../../../src/utility/formatName"); | ||
| const { getSDK } = require("./utils"); | ||
|
|
There was a problem hiding this comment.
Seems unnecessary, plus I prefer we keep the spacing here to keep things more organized
geodem127
force-pushed
the
test/seed-data-content-list
branch
from
28425c1 to
5e4fb0a
Compare
geodem127
force-pushed
the
test/seed-data-content-list
branch
from
5e4fb0a to
78026f2
Compare
NOTE: This work is based on and requires #3899 to be merged first.