Blocks - Refetch content model data when a block model is generated #3924
Conversation
src/shell/views/Shell/AIDrawer.tsx
Outdated
| } | ||
|
|
||
| // Makes sure that the subapp sidebar data is refreshed | ||
| if (response.type === "NAVIGATE") { |
There was a problem hiding this comment.
This means that everytime the model responds with a navigate action it refetches regardless if the user even clicked on the navigate button.
In addition the navigate action is context free it may navigate to settings for example so there are cases where there is no need to refetch content models
There was a problem hiding this comment.
@agalin920 I've updated it to only perform a refetch when the response path contains "blocks", this way it would only refetch when a new block is generated. I decided to perform the refetch as soon as the response is received from the mcp, this way even if the user was already on the blocks app the sidebar would automatically get updated instead of having to wait for the user to click the Navigate button before doing the refetch.
There was a problem hiding this comment.
This is a bit too brittle. Let's talk to @mattezra to return the created entities as part of the response so it can be applied to any entity that we may support in the future.
For now simply ensuring blocks get refreshed when navigating to the blocks app should suffice
There was a problem hiding this comment.
return the crested entities as part of the response so it can be applied to any entity that we may support in the future.
@agalin920 I'm not sure I understand what this is for.
Also, are you suggesting the refetch be done once the navigate button is clicked? If so, what if the user decided to not click the navigate button, wouldn't that mean that they won't be able to see the new block item on the subapp sidebar until it gets refetched some other way?
There was a problem hiding this comment.
As discussed, I have moved the refetch call to the onClick of the navigate button
There was a problem hiding this comment.
@finnar-bin that wasn't really the solution discussed. The solution we want as part of this is to gurantee block model refetch when navigating to the blocks app
…d `refetchOnMountOrArgChange` to Sidebar's content model query.
Ensures that the content model data rtk cache is invalidated when a block model is generated via AI so that the subapp nav will immediately contain the newly-generated block.
Resolves #3923
Screencast_20251204_094345.webm