Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown field errors when querying pre-v19 height cosmos transactions #2835

Closed
GMaiolo opened this issue Sep 5, 2024 · 6 comments · Fixed by #2909
Closed

Unknown field errors when querying pre-v19 height cosmos transactions #2835

GMaiolo opened this issue Sep 5, 2024 · 6 comments · Fixed by #2909
Assignees
Labels
bug Something isn't working

Comments

@GMaiolo
Copy link

GMaiolo commented Sep 5, 2024

Describe the Bug
When querying /cosmos/tx/v1beta1/txs?events=tx.height=4667204&page=1&limit=100&pagination.count_total=true
With heights previous to the v19 update, nodes fail errors like the following

{
  "code": 2,
  "message": "codespace sdk code 2: tx parse error: errUnknownField \"*types.MsgVoteGasPrice\": {TagNum: 5, WireType:\"bytes\"}",
  "details": []
}

To Reproduce
Query a pre-v19 block like /cosmos/tx/v1beta1/txs?events=tx.height=4667204&page=1&limit=100&pagination.count_total=true

Expected Behavior
Transactions data should be returned successfully

@GMaiolo GMaiolo added the bug Something isn't working label Sep 5, 2024
@GMaiolo
Copy link
Author

GMaiolo commented Sep 9, 2024

Another example
/cosmos/tx/v1beta1/txs?events=tx.height=4687821&page=1&limit=1&pagination.count_total=true

Result

{
  "code": 2,
  "message": "codespace sdk code 2: tx parse error: unable to resolve type URL /zetachain.zetacore.crosschain.MsgVoteOnObservedInboundTx",
  "details": []
}

@kingpinXD
Copy link
Contributor

Both the example contain proto buffers which have been modified

  • VoteGasPrice . The supply field with ID 5 was removed
  • MsgVoteOnObservedInboundTx was renamed to VoteInbound

@GMaiolo
Copy link
Author

GMaiolo commented Sep 16, 2024

@kingpinXD would this impact someone that tries to create an indexer for ZetaChain from genesis?

@kingpinXD
Copy link
Contributor

This would impact someone trying to sync from block 1 , if they use the current binary and try to fetch older transactions

@kingpinXD
Copy link
Contributor

v21 modifies the UpdateChainInfo message , and is a breaking change
We should verify on athens 3 , that we do not run into a similar issues as this
#2890

@GMaiolo
Copy link
Author

GMaiolo commented Oct 15, 2024

@lumtis does this need an update on the nodes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants