refactor(authority): message update chain info to update single chains #2890
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe pull request introduces significant modifications to the chain management functionality within the ZetaChain framework. It refactors the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant MsgServer
participant Keeper
User->>CLI: Execute remove-chain-info [chain-id]
CLI->>MsgServer: Send MsgRemoveChainInfo
MsgServer->>Keeper: RemoveChainInfo(chain-id)
Keeper-->>MsgServer: Confirmation of removal
MsgServer-->>CLI: Response success
CLI-->>User: Display success message
Assessment against linked issues
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2890 +/- ##
===========================================
+ Coverage 67.12% 67.20% +0.07%
===========================================
Files 378 380 +2
Lines 21121 21170 +49
===========================================
+ Hits 14178 14227 +49
Misses 6276 6276
Partials 667 667
|
kingpinXD
changed the title
kingpinXD
requested review from
brewmaster012,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Outside diff range and nitpick comments (4)
docs/spec/authority/messages.md (2)
16-24: The changes toMsgUpdateChainInfoenhance clarity and align with the PR objectives.The modifications to the message documentation provide a clearer understanding of how the message operates regarding the management of chain information. The changes are consistent with the PR objectives and the linked issue, which aim to streamline the process of managing chain information and enhance the clarity and functionality of the system.
Suggestion: Fix the formatting issues.
The static analysis hints indicate some formatting issues related to the use of hard tabs. Consider replacing the hard tabs with spaces to improve the consistency and readability of the documentation.
Tools
Markdownlint
22-22: Column: 1
Hard tabs(MD010, no-hard-tabs)
23-23: Column: 1
Hard tabs(MD010, no-hard-tabs)
27-34: The introduction ofMsgRemoveChainInfoenhances the functionality and aligns with the PR objectives.The addition of the
MsgRemoveChainInfomessage expands the functionality related to chain management by allowing for the removal of chain information based on a specified chain ID. This change reflects a more comprehensive approach to handling chain information, enabling both updates and removals. The message is consistent with the PR objectives and the linked issue, which emphasize the necessity of introducing a new message type that allows for the removal of an existing chain.Suggestion: Fix the formatting issues.
The static analysis hints indicate some formatting issues related to the use of hard tabs. Consider replacing the hard tabs with spaces to improve the consistency and readability of the documentation.
Tools
Markdownlint
33-33: Column: 1
Hard tabs(MD010, no-hard-tabs)
34-34: Column: 1
Hard tabs(MD010, no-hard-tabs)
x/authority/keeper/msg_server_update_chain_info.go (1)
Line range hint
12-49: Consider refactoring the function to separate the update and add logic.The
UpdateChainInfofunction currently handles both updating an existing chain and adding a new chain. To improve readability and maintainability, consider refactoring the function to separate these two responsibilities into separate methods.For example, you can create two separate methods:
func (k msgServer) updateExistingChain(ctx sdk.Context, chainInfo types.ChainInfo, chain types.Chain) (types.ChainInfo, error) { for i, existingChain := range chainInfo.Chains { if existingChain.ChainId == chain.ChainId { chainInfo.Chains[i] = chain return chainInfo, nil } } return chainInfo, errors.Wrap(types.ErrChainNotFound, "chain not found") } func (k msgServer) addNewChain(ctx sdk.Context, chainInfo types.ChainInfo, chain types.Chain) types.ChainInfo { chainInfo.Chains = append(chainInfo.Chains, chain) return chainInfo }Then, you can update the
UpdateChainInfofunction to use these methods:func (k msgServer) UpdateChainInfo(goCtx context.Context, msg *types.MsgUpdateChainInfo) (*types.MsgUpdateChainInfoResponse, error) { // ... chainInfo := types.ChainInfo{} if found { chainInfo = cf updatedChainInfo, err := k.updateExistingChain(ctx, chainInfo, msg.Chain) if err != nil && !errors.Is(err, types.ErrChainNotFound) { return nil, err } if err == nil { chainInfo = updatedChainInfo } } if len(chainInfo.Chains) == 0 || errors.Is(err, types.ErrChainNotFound) { chainInfo = k.addNewChain(ctx, chainInfo, msg.Chain) } k.SetChainInfo(ctx, chainInfo) return &types.MsgUpdateChainInfoResponse{}, nil }This refactoring makes the code more readable and maintainable by separating the update and add logic into separate methods.
x/authority/keeper/msg_server_update_chain_info_test.go (1)
106-106: Fix the typo in the test case name.Please change "dos" to "does" in the test case name for clarity.
Apply this diff to fix the typo:
-t.Run("add chain to chain info if chain dos not exist", func(t *testing.T) { +t.Run("add chain to chain info if chain does not exist", func(t *testing.T) {
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
typescript/zetachain/zetacore/authority/tx_pb.d.tsis excluded by!**/*_pb.d.tsx/authority/types/tx.pb.gois excluded by!**/*.pb.go,!**/*.pb.go
Files selected for processing (23)
- changelog.md (1 hunks)
- docs/cli/zetacored/cli.md (2 hunks)
- docs/openapi/openapi.swagger.yaml (1 hunks)
- docs/releases/v21_breaking_changes.md (1 hunks)
- docs/spec/authority/messages.md (1 hunks)
- proto/zetachain/zetacore/authority/tx.proto (3 hunks)
- testutil/testdata/types/chain.json (1 hunks)
- x/authority/client/cli/tx.go (1 hunks)
- x/authority/client/cli/tx_remove_chain_info.go (1 hunks)
- x/authority/client/cli/tx_update_chain_info.go (3 hunks)
- x/authority/client/cli/tx_update_chain_info_test.go (1 hunks)
- x/authority/keeper/msg_server_remove_chain_info.go (1 hunks)
- x/authority/keeper/msg_server_remove_chain_info_test.go (1 hunks)
- x/authority/keeper/msg_server_update_chain_info.go (2 hunks)
- x/authority/keeper/msg_server_update_chain_info_test.go (4 hunks)
- x/authority/types/authorization_list.go (1 hunks)
- x/authority/types/authorization_list_test.go (1 hunks)
- x/authority/types/codec.go (1 hunks)
- x/authority/types/errors.go (1 hunks)
- x/authority/types/message_remove_chain_info.go (1 hunks)
- x/authority/types/message_remove_chain_info_test.go (1 hunks)
- x/authority/types/message_update_chain_info.go (2 hunks)
- x/authority/types/message_update_chain_info_test.go (3 hunks)
Additional context used
Path-based instructions (17)
x/authority/client/cli/tx.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/codec.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/client/cli/tx_update_chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/client/cli/tx_remove_chain_info.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/errors.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/message_remove_chain_info.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/message_update_chain_info.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/client/cli/tx_update_chain_info.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/keeper/msg_server_remove_chain_info.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/keeper/msg_server_update_chain_info.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/message_update_chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/message_remove_chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.proto/zetachain/zetacore/authority/tx.proto (1)
Pattern
**/*.proto: Review the Protobuf definitions, point out issues relative to compatibility, and expressiveness.x/authority/keeper/msg_server_update_chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/authorization_list.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/keeper/msg_server_remove_chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/authorization_list_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Markdownlint
docs/releases/v21_breaking_changes.md
4-4: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
7-7: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
8-8: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
9-9: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
10-10: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
11-11: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
docs/spec/authority/messages.md
22-22: Column: 1
Hard tabs(MD010, no-hard-tabs)
23-23: Column: 1
Hard tabs(MD010, no-hard-tabs)
33-33: Column: 1
Hard tabs(MD010, no-hard-tabs)
34-34: Column: 1
Hard tabs(MD010, no-hard-tabs)
docs/cli/zetacored/cli.md
8177-8177: Column: 88
Hard tabs(MD010, no-hard-tabs)
8338-8338: Column: 52
Hard tabs(MD010, no-hard-tabs)
8291-8291: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
8297-8297: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
8328-8328: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Additional comments not posted (41)
docs/openapi/openapi.swagger.yaml (1)
56841-56843: LGTM!The addition of the
authorityMsgRemoveChainInfoResponseobject definition enhances the API documentation by providing a clear description of theMsgRemoveChainInfoResponseservice. The change is well-structured, follows the existing naming conventions, and improves the overall clarity and usability of the API specification.testutil/testdata/types/chain.json (1)
1-9: LGTM! Consider updating with real-world configurations before deployment.The JSON object provides a well-structured configuration for a blockchain entity, encapsulating essential parameters for its operation. The fields and their assigned values appear to be placeholders or test values, which is appropriate for a test data file.
However, before deploying this configuration to a production environment, ensure that the values are updated with real-world configurations that align with the intended blockchain network and its associated components.
docs/releases/v21_breaking_changes.md (1)
6-11: The content accurately describes the breaking changes.The content in this section clearly and concisely describes the changes to the
update_chain_infomessage and the introduction of the newRemoveChainInfotransaction type. The description provides sufficient details about the changes and their implications for users.Tools
Markdownlint
7-7: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
8-8: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
9-9: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
10-10: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
11-11: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
x/authority/client/cli/tx.go (1)
25-25: LGTM: The addition of theCmdRemoveChainInfo()command enhances the chain management functionality.The inclusion of the
CmdRemoveChainInfo()command in theGetTxCmd()function aligns with the PR objectives and the linked issue, which emphasize the need for a new message type to remove an existing chain. This addition contributes to a more comprehensive chain management capability, allowing users to remove chain information through the command-line interface.The placement and syntax of the command are correct, and no issues are apparent.
x/authority/types/codec.go (2)
13-13: LGTM!The registration of
MsgRemoveChainInfoas a concrete type in the codec is done correctly, following the same pattern as other message types. This is necessary for proper serialization and deserialization of the message.
20-20: LGTM!The registration of
MsgRemoveChainInfoas an implementation of thesdk.Msginterface is done correctly, following the same pattern as other message types. This is necessary for the message to be recognized as a valid message type in the SDK.x/authority/client/cli/tx_update_chain_info_test.go (1)
13-36: Excellent restructuring of the test function.The changes made to the
TestReadChainInfoFromFilefunction significantly improve the clarity and organization of the test cases. By utilizingt.Run()to create sub-tests, the code clearly delineates the different scenarios being tested, making it easier to understand and maintain.The first sub-test, "successfully read file," effectively verifies that the
cli.ReadChainFromFilefunction correctly reads a valid chain configuration from the specified JSON file. It compares the returned chain against an expectedchains.Chainstructure, ensuring the accuracy of the reading functionality.The second sub-test, "file not found," appropriately tests the error handling of the
cli.ReadChainFromFilefunction when attempting to read from a non-existent file. It asserts that an error is returned, confirming the function's ability to handle this edge case gracefully.Overall, the restructured test function covers both positive and negative scenarios, enhancing the robustness and reliability of the
cli.ReadChainFromFilefunction. The changes adhere to best practices for writing clear and comprehensive test cases.x/authority/client/cli/tx_remove_chain_info.go (1)
14-39: Excellent implementation of the CLI command for removing chain information.The
CmdRemoveChainInfofunction is well-structured, follows best practices, and effectively implements the desired functionality. The command usage, description, and arguments are clearly defined, and the error handling is appropriate.The function correctly retrieves the transaction context, parses the chain ID, constructs a message of type
MsgRemoveChainInfo, and generates or broadcasts the transaction using the CLI's transaction handling capabilities. The command flags are also properly added to the command.Overall, the implementation is clean, concise, and production-grade.
x/authority/types/errors.go (1)
15-16: LGTM!The new error variable
ErrChainInfoNotFoundis declared and registered correctly, following the existing code style and conventions in the file. The error code is unique and the error message is clear and concise, indicating that the chain info was not found.The addition of this error variable enhances the error handling capabilities of the module by providing a specific error for cases where chain information is not found, improving the clarity and specificity of error reporting.
x/authority/types/message_update_chain_info.go (3)
7-8: LGTM!The import statement is necessary and correctly added to use the
chains.Chaintype in the file.
15-18: LGTM!The modification to the
NewMsgUpdateChainInfofunction signature aligns with the objective of refactoring theMsgUpdateChainInfoto accept a single chain. The usage of thechains.Chaintype provides a more specific representation of chain information.
48-51: LGTM!The update to the validation logic in the
ValidateBasicmethod correctly reflects the change in theMsgUpdateChainInfostructure to use thechains.Chaintype. The validation is performed by calling theValidatemethod on theChainfield, ensuring that the chain adheres to its own validation rules.x/authority/client/cli/tx_update_chain_info.go (2)
24-24: LGTM!The function has been updated to use the new
ReadChainFromFilefunction, which aligns with the refactored functionality. The logic is correct, and the implementation is accurate.
46-54: LGTM!The function has been appropriately renamed and refactored to align with the updated functionality. The logic is correct, and the implementation is accurate. The changes in the function name and return type provide clarity and consistency with the broader refactor.
x/authority/keeper/msg_server_remove_chain_info.go (2)
12-33: LGTM!The
RemoveChainInfofunction is well-structured and follows the expected flow:
- It checks the authorization and returns an error if unauthorized.
- It retrieves the existing chain info and returns an error if not found.
- It calls
RemoveChainto remove the specified chain from the chain info.- It saves the updated chain info back to the store.
The implementation is correct and aligns with the PR objectives.
35-45: LGTM!The
RemoveChainfunction is a clean and concise implementation for removing a chain from theChainInfoobject:
- It iterates through the existing chains.
- It only adds the chains that don't match the specified chain ID to the new
ChainInfoobject.- If the specified chain ID doesn't exist, the original chain info is returned unchanged.
The implementation is correct and aligns with the PR objectives.
x/authority/types/message_update_chain_info_test.go (6)
22-22: LGTM!The test case is creating a valid message using the
NewMsgUpdateChainInfofunction with a sample address and chain. The usage of thesample.Chainfunction to create a sample chain with an ID of 42 is appropriate.
26-26: LGTM!The test case is correctly testing the scenario where an invalid creator address is provided to the
NewMsgUpdateChainInfofunction. The usage of thesample.Chainfunction to create a sample chain with an ID of 42 is appropriate, and the expected error containing the string "invalid creator address" is being checked.
30-32: LGTM!The test case is correctly testing the scenario where an invalid chain with a negative ID is provided to the
NewMsgUpdateChainInfofunction. The expected error containing the string "invalid chain" is being checked.
57-57: LGTM!The test case is correctly testing the scenario where a valid signer is provided to the
NewMsgUpdateChainInfofunction. The usage of thesample.Chainfunction to create a sample chain with an ID of 42 is appropriate, and the test case expects no panic when calling theGetSignersmethod on the message.
62-62: LGTM!The test case is correctly testing the scenario where an invalid signer is provided to the
NewMsgUpdateChainInfofunction. The usage of thesample.Chainfunction to create a sample chain with an ID of 42 is appropriate, and the test case expects a panic when calling theGetSignersmethod on the message.
82-82: LGTM!The remaining changes in the
TestMsgUpdateChainInfo_Type,TestMsgUpdateChainInfo_Route, andTestMsgUpdateChainInfo_GetSignBytestest functions are using theNewMsgUpdateChainInfofunction with a sample address and chain to create a valid message for testing theType,Route, andGetSignBytesmethods of theMsgUpdateChainInfomessage. The changes are appropriate and there are no apparent issues.Also applies to: 87-87, 92-92
x/authority/types/message_remove_chain_info_test.go (4)
13-40: LGTM!The test function
TestMsgRemoveChainInfo_ValidateBasicis well-structured and covers the essential scenarios for testing theValidateBasicmethod ofMsgRemoveChainInfo. The use of table-driven tests and thesample.AccAddress()function for generating valid addresses is a good practice. The test cases also check for specific error messages when an error is expected, which is a thorough approach.
42-73: LGTM!The test function
TestMsgRemoveChainInfo_GetSignersis well-structured and covers the essential scenarios for testing theGetSignersmethod ofMsgRemoveChainInfo. The use of table-driven tests and thesample.AccAddress()function for generating valid addresses is a good practice. The test cases also check for panics when an invalid signer is provided, which is a good way to ensure the expected behavior.
75-78: LGTM!The test function
TestMsgRemoveChainInfo_Typeis simple and straightforward. It checks if the returned message type matches the expected constant value, which is sufficient for testing theTypemethod ofMsgRemoveChainInfo.
80-83: LGTM!The test function
TestMsgRemoveChainInfo_Routeis simple and straightforward. It checks if the returned route key matches the expected constant value, which is sufficient for testing theRoutemethod ofMsgRemoveChainInfo.proto/zetachain/zetacore/authority/tx.proto (5)
7-7: Import statement looks good.The import statement for
chains.protofollows the expected convention and suggests a dependency on chain-related definitions, which aligns with the objectives of this pull request.
16-16: RPC method for removing chain information looks good.The
RemoveChainInfoRPC method follows the naming convention, enhances the functionality of the authority service, and has a consistent signature with the other methods in the service.
58-58: Improved chain information representation inMsgUpdateChainInfo.The change from
ChainInfotopkg.chains.Chainsuggests a more structured and detailed representation of chain data, which aligns with the objectives of this pull request. The updated field namechainis more concise and consistent with the message name. The(gogoproto.nullable) = falseoption ensures that the field is required, preventing ambiguity and potential errors.
64-68: NewMsgRemoveChainInfomessage type for chain removal.The
MsgRemoveChainInfomessage type follows the naming convention and includes the essential fields required for chain removal:creator(the address of the user initiating the removal) andchain_id(the identifier of the chain to be removed). The message structure is simple and focused, which aligns with the objectives of this pull request and enhances the clarity of the chain removal process.
70-71: NewMsgRemoveChainInfoResponsemessage type for confirmation.The
MsgRemoveChainInfoResponsemessage type follows the naming convention and serves as a confirmation of the chain removal operation initiated by theMsgRemoveChainInfomessage. Although the message is empty, its presence maintains consistency with the other message types in the service and provides a clear indication of the successful completion of the chain removal process.x/authority/keeper/msg_server_update_chain_info_test.go (3)
Line range hint
32-62: LGTM!The test case is well-structured and correctly verifies the behavior of setting a new chain info when it doesn't exist. The assertions are appropriate and cover the necessary conditions.
81-103: LGTM!The test case effectively verifies the behavior of updating an existing chain info. It sets up the initial state, updates the chain name, and correctly asserts that the stored chain info reflects the updated name.
Line range hint
106-136: LGTM!The test case correctly verifies the behavior of adding a new chain to the existing chain info. It sets up the initial state, creates a new chain with a different ID, and asserts that the stored chain info is updated and contains the new chain.
x/authority/types/authorization_list.go (1)
42-42: LGTM!The addition of the new message URL
"/zetachain.zetacore.authority.MsgRemoveChainInfo"to theAdminPolicyMessagesslice is appropriate and consistent with the existing code structure. It suggests a new functionality to remove chain info, which aligns with the admin policy's responsibilities.x/authority/keeper/msg_server_remove_chain_info_test.go (2)
15-155: LGTM!The
TestMsgServer_RemoveChainInfofunction thoroughly tests theRemoveChainInfomethod of theMsgServerunder various conditions. The test cases cover the important scenarios, and the assertions are correct. The test function is well-structured and follows the Arrange-Act-Assert pattern.
157-184: LGTM!The
TestMsgServer_RemoveChainfunction thoroughly tests theRemoveChainhelper function using a table-driven testing approach. The test cases cover the important scenarios, and the assertions are correct. The test function is well-structured and easy to understand.x/authority/types/authorization_list_test.go (1)
433-433: LGTM!The addition of the
MsgRemoveChainInfomessage type to the admin policy message list is consistent with the PR objective and the linked issue. The code change is straightforward and logically sound.changelog.md (1)
19-19: Changelog entry looks good.The entry accurately describes the refactoring of
MsgUpdateChainInfoand the addition ofMsgRemoveChainInfo. The pull request number is provided for traceability.docs/cli/zetacored/cli.md (2)
8177-8177: LGTM!The addition of the new
zetacored tx authority remove-chain-infocommand in the table of contents is valid and consistent with the surrounding entries.Tools
Markdownlint
8177-8177: Column: 88
Hard tabs(MD010, no-hard-tabs)
8287-8339: LGTM!The addition of the new
zetacored tx authority remove-chain-infocommand section is valid and follows the structure of other command sections in the document. The description, usage, options, and options inherited from parent commands are clearly documented.Tools
Markdownlint
8338-8338: Column: 52
Hard tabs(MD010, no-hard-tabs)
8291-8291: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
8297-8297: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
8328-8328: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
kingpinXD
changed the title
Description
update_chain_infomessage has been refactored to update/add a single chain ,instead of providing the entire list asChainInfoRemoveChainInfohas also been added to remove a chain from the list of chains.Closes #2815
How Has This Been Tested?
Summary by CodeRabbit
New Features
zetacoredCLI.MsgRemoveChainInfo, for removing chain data.MsgUpdateChainInfofunctionality to streamline updates for individual chains.Bug Fixes
Documentation
Tests
MsgRemoveChainInfofunctionality and updated existing tests for clarity.