Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow parsing Bitcoin deposit memo with inscription #2957

Merged
merged 8 commits into from
Oct 4, 2024

fix the error for BTC donations

394aa65
Select commit
Loading
Failed to load commit list.
Merged

feat: allow parsing Bitcoin deposit memo with inscription #2957

fix the error for BTC donations
394aa65
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2024 in 0s

66.40% (+0.00%) compared to f0ed61d

View this Pull Request on Codecov

66.40% (+0.00%) compared to f0ed61d

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.40%. Comparing base (f0ed61d) to head (394aa65).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
zetaclient/chains/bitcoin/observer/inbound.go 75.00% 1 Missing ⚠️
zetaclient/chains/bitcoin/observer/witness.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2957   +/-   ##
========================================
  Coverage    66.39%   66.40%           
========================================
  Files          389      389           
  Lines        21758    21766    +8     
========================================
+ Hits         14447    14454    +7     
- Misses        6584     6585    +1     
  Partials       727      727           
Files with missing lines Coverage Δ
zetaclient/chains/bitcoin/observer/inbound.go 18.90% <75.00%> (+0.78%) ⬆️
zetaclient/chains/bitcoin/observer/witness.go 71.73% <0.00%> (ø)

... and 2 files with indirect coverage changes