-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate typescript bindings #825
Conversation
Just wondering, why is it in draft? |
I want the fullstack team to check it out and try using to see if we have everything in place before merging. |
Could we remove the Is it possible to have an
With
This way, we can consume types directly from the known folder ( |
@GMaiolo done! ✅ |
@lucas-janon can you, please, add an npm token, so we can set it up to publish automatically when a release is created. |
@fadeev could we manually publish a |
I can't publish, because I don't have an npm token. Have you tried with |
Can we put as ready for review @fadeev ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run make typescript
with the latest changes?
I get several modified files when I run the command
@GMaiolo can you, please, review the code generated in this PR and let us know if this matches your requirements? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
make typescript
should generate TS bindings in./typescript
.Using https://buf.build/blog/protobuf-es-the-protocol-buffers-typescript-javascript-runtime-we-all-deserve
We probably don't need TS bindings in the repo. This should be generated automatically on release and published on
npm
.