Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate crosschain keeper #829

Merged
merged 33 commits into from
Jul 25, 2023

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Jul 20, 2023

Description

  • Moves Node_Accounts, KeyGen, and Permission_Flags from cross-chain to observer module

  • Adds a check for the observer set , which executes at every block, If this check fails (the observer set changes for some reason), It will
    - Pause Inbound Tx ( as new TSS will need to be generated)
    - Reset KeyGen back to pending status

  • Once the inbound pauses, the following step would need to be done

    • Modify the node account list to remove/add new observers. (Can add a Policy based TX for this in a separate PR)
    • Set KeyGen Height for a new block to generate a new TSS

Closes:
#815
#830

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD marked this pull request as ready for review July 20, 2023 19:15
@kingpinXD kingpinXD changed the title Refactor/migrate crosschain keeper refactor: migrate crosschain keeper Jul 21, 2023
@kingpinXD kingpinXD merged commit acca420 into develop Jul 25, 2023
16 checks passed
@kingpinXD kingpinXD deleted the refactor/migrate-crosschain-keeper branch July 25, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add migration function for v6 refactoring the keeper state for crosschain module
3 participants