Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: generated files check #873

Merged
merged 10 commits into from
Aug 7, 2023
Merged

ci: generated files check #873

merged 10 commits into from
Aug 7, 2023

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jul 28, 2023

  • Renamed the workflow to "Generated Files are Updated"
  • Added make specs to the "Generated Files" check
  • Moved OpenAPI generation into a separate Makefile target: make openapi
  • Added a make generated target to generate all the things

@fadeev fadeev changed the title Generated files check ci: generated files check Jul 28, 2023
@fadeev fadeev marked this pull request as ready for review July 28, 2023 15:41
@fadeev fadeev requested a review from lumtis July 28, 2023 15:41
@fadeev
Copy link
Member Author

fadeev commented Jul 28, 2023

Ironically, the "Generated Files are Updated" check is failing for this PR, because #871 has to be merged first.

.github/workflows/generate-files.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
fadeev and others added 2 commits July 31, 2023 12:37
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@fadeev fadeev requested a review from lumtis July 31, 2023 08:38
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@fadeev fadeev requested a review from lumtis July 31, 2023 09:54
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of the action error. Not sure if it is related to this PR since CI currently fails for other PR as well?

@fadeev
Copy link
Member Author

fadeev commented Jul 31, 2023

Yeah, build fails for some reason not related to this PR.

@fadeev fadeev requested a review from ws4charlie as a code owner August 6, 2023 07:22
@fadeev
Copy link
Member Author

fadeev commented Aug 7, 2023

Can't merge I believe because the build task gets cancelled.

@fadeev fadeev merged commit e3f715e into develop Aug 7, 2023
15 checks passed
@fadeev fadeev deleted the generated-files-check branch September 1, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants