Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix build test #903

Merged
merged 11 commits into from
Aug 3, 2023
Merged

ci: fix build test #903

merged 11 commits into from
Aug 3, 2023

Conversation

CharlieMc0
Copy link
Member

Description

Fixing build test step

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@CharlieMc0 CharlieMc0 self-assigned this Aug 2, 2023
@CharlieMc0 CharlieMc0 changed the title ci - fix build test ci: fix build test Aug 2, 2023
@lumtis
Copy link
Member

lumtis commented Aug 3, 2023

The build-and-test action failure seems to constantly happens in this line
https://github.com/zeta-chain/node/blob/55e440e698d3f7d8fb41fd80d79ed8525329b19c/x/crosschain/client/integrationtests/inbound_voter_test.go#L135C1-L135C1
for this test case

name: "All observers voted success",

isn't a chance that this particular test case is wrong? even though I can't see how

@CharlieMc0 CharlieMc0 merged commit 487a54b into develop Aug 3, 2023
16 checks passed
@CharlieMc0 CharlieMc0 deleted the ci-fix-build-test branch August 3, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants