-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(testutil
): add keeper reference mocks in fungible test keeper
#909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
changed the title
WIP - test(
test(Aug 8, 2023
testutil
): add keeper reference mocks in fungible test keepertestutil
): add keeper reference mocks in fungible test keeper
lumtis
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
ws4charlie
as code owners
August 8, 2023 09:52
brewmaster012
approved these changes
Aug 10, 2023
kingpinXD
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace empty keeper instances with mocks in fungible keepers for isolated unit testing.
The mocking system uses mockery utility: https://vektra.github.io/mockery/latest/
The mocks are generated by running the generation commands in
testutil/keeper/mocks.go
:The generated structures are located in
..../mocks/[modulename]/[mockedmodule].go
The generated structures can be initialized with the
New...
methodsDependent on #900
Closes: #901
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: