Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove upper cases in import package names #908 #917

Closed
wants to merge 0 commits into from

Conversation

aks3213
Copy link

@aks3213 aks3213 commented Aug 7, 2023

Description

This PR comprises changes related to updating import from camelcase to lowercase and improving package alias name of imports

Closes: #908

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactoring code

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis
Copy link
Member

lumtis commented Aug 7, 2023

@aks3213 thank you so much for the PR, I will have a look today

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one comment otherwise looks good.

testutil/keeper/fungible.go Outdated Show resolved Hide resolved
zetaclient/keys_test.go Outdated Show resolved Hide resolved
@lumtis lumtis changed the title refactor: Remove upper cases in import package names #908 refactor: remove upper cases in import package names #908 Aug 7, 2023
@lumtis
Copy link
Member

lumtis commented Aug 8, 2023

@aks3213 it looks legit to me 👍
We are working to make the CI works, once those pass and there is a second review, it should be good to go.

@aks3213
Copy link
Author

aks3213 commented Aug 9, 2023

Let me know if any actions are required from my side..

@lumtis
Copy link
Member

lumtis commented Aug 9, 2023

Let me know if any actions are required from my side..

You can merge develop once #936 is merged

@CharlieMc0
Copy link
Member

@aks3213 we've fixed the CI. Please sync with the latest changes and address the conflict. Once that's been resolved the CI will run correctly and we can merge it in.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove upper cases in import package names
3 participants