feat: msg update withdraw fee #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and smoketest
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
brewmaster012
requested review from
kingpinXD,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
lumtis
reviewed
Aug 9, 2023
ws4charlie
reviewed
Aug 10, 2023
| @@ -77,5 +76,6 @@ func (k Keeper) UpdateSystemContract(goCtx context.Context, msg *types.MsgUpdate | |||
| k.Logger(ctx).Error("failed to emit event", "error", err.Error()) | |||
| return nil, sdkerrors.Wrapf(types.ErrEmitEvent, "failed to emit event (%s)", err.Error()) | |||
| } | |||
| commit() | |||
There was a problem hiding this comment.
If commit after successfully emitting event is more correct, I‘m wondering if we have other places doing the same early commit.
There was a problem hiding this comment.
go hunt them down!
lumtis
approved these changes
Aug 10, 2023
kingpinXD
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #927
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: