Merge pull request #2337 from zetkin/issue-2330/smart-search-gender-d…

…efault-value

Set or clear value when switching to/from gender filter

src/features/smartSearch/components/filters/PersonData/index.tsx

@@ -98,10 +98,20 @@ const PersonData = ({
     if (field === REMOVE_FIELD) {
       setCriteria(criteria.filter((criterion) => criterion.field !== c.field));
     } else {
+      let value = c.value;
+      // Default value for gender is 'f'
+      if (field === DATA_FIELD.GENDER) {
+        value = 'f';
+      }
+
+      // It doesn't make sense to use the gender value when changing to other fields
+      if (c.field === DATA_FIELD.GENDER) {
+        value = '';
+      }
       setCriteria(
         criteria.map((criterion) => {
           return criterion.field === c.field
-            ? { ...criterion, field: field as DATA_FIELD }
+            ? { field: field as DATA_FIELD, value }
             : criterion;
         })
       );