Improvements to ZUIEditor overlays
#2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
changed the title
ZUIEditor overlays fixesZUIEditor overlays
ziggabyte
requested changes
Jan 20, 2025
There was a problem hiding this comment.
I could not catch it on screenshot for some reason, but I can reach a state where the red line with the "add" button appears on top of the blinking caret, like the red line is off somehow to where it should be?
Did not get this state in the other pr so I am assuming this is something that has happened in here..
I'm putting "request for change" to look into it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a number of issues related to the overlays over
ZUIEditor.Screenshots
Changes
BlockInsertusing an approach based onview.nodeDOM().getBoundingClientRect()instead ofview.coordsAtPos()insertParagraph()command when used immediately before an image block'/'which triggers block menu to openNotes to reviewer
I'm mostly happy with this, but we do need to talk a little bit about the UX, especially related to the placeholder.
Related issues
Undocumented