This repository was archived by the owner on May 21, 2023. It is now read-only.
Fix memory leaks for GPU thread snd web server thread#8
Open
AlexandrShcherbakov wants to merge 2 commits intozeux:upstreamfrom
Open
Fix memory leaks for GPU thread snd web server thread#8AlexandrShcherbakov wants to merge 2 commits intozeux:upstreamfrom
AlexandrShcherbakov wants to merge 2 commits intozeux:upstreamfrom
Conversation
zeux
reviewed
Mar 5, 2019
| { | ||
| //for meta, store the count + 3, which is the tick part | ||
| nLogType = 3 + MicroProfileLogGetTick(pLog->Log[k]); | ||
| MicroProfileGetMutex().unlock(); |
Owner
There was a problem hiding this comment.
This is definitely not thread-safe since pLog can be deallocated if the thread exits. It also doesn't seem related to the PR in question, and may carry a large cost.
Owner
|
I don't think this is targeting the correct branch; it should target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.