zf1s/zf1: require php extensions in dev only #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup on #133, #128 (comment)
It is probably too restrictive to have them listed in
require
section in the rootcomposer.json
file.Composer will complain that an extension is not installed, e.g.
ext-ldap
forZend_Ldap
, even if it's not needed i.e. a project is not usingZend_Ldap
at all.Due to the nature of zf1, you may never need some of the extensions, as long as you do not use components which require them. But when you start using them, those components themselves should throw errors that required extensions are not installed.
Moved to
require-dev
to ensure they are installed when running tests on dev/CI.I've considered adding them to
suggest
section but imo composer might spam too much with irrelevant information, when installingzf1s/zf1
package.ref: #128 (comment)