-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php8.2 compat: add missing class properties #170
Conversation
18e95d8
to
7343924
Compare
ce827da
to
c59c032
Compare
For what it is worth, I tried this branch and now all my 500 unit tests are passing and my website works on PHP 8.2. Keep up the great work 👍 🙏 |
Is there a release plan? |
Sure, any help would be greatly appreciated :) There are still 3 failures and 200+ errors, see the php 8.2 workflow. @maksimovic addressed memcache issues in #169 but those fixes still need to be extracted to a separate PR. Most of the issues are triggered by accessing dynamic props on Zend view and form element. And there are a bunch of smaller ones. |
Good. |
I can help, but could you please guide me on how I can get started and what should I do? |
c59c032
to
f4af896
Compare
Fixing issues on PHP 8.2 like > Deprecated: Creation of dynamic property {x} is deprecated Signed-off-by: Elan Ruusamäe <glen@pld-linux.org> Co-authored-by: Elan Ruusamäe <glen@pld-linux.org> (cherry picked from commit 65c1385dce02591d31b1165283ed7f8e018badfd)
Co-authored-by: hungtd <trinhduchung@gmail.com> (cherry picked from commit bdbfa1dcda95797a74a6cb5f80890e606b23f239)
Ported from Shardj/zf1-future#289 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Ported from Shardj/zf1-future#291 PHP 8.2: Dynamic Properties are deprecated fix Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
as Zend_Controller_Action_Helper_ContextSwitch uses that
php 8.2+ needs this otherwise `stream_wrapper_register('php', 'Zend_AllTests_StreamWrapper_PhpInput');` triggers `Creation of dynamic property Zend_AllTests_StreamWrapper_PhpInput::$context is deprecated`
Creation of dynamic property PHPUnit_Extensions_Database_DataSet_CompositeDataSet::$motherDataset is deprecated
f4af896
to
9cd333f
Compare
in (probably defunc for a long time already) service components and tests
1.15.3 is released now, bringing compatibility with php 8.2 & 8.3. |
ported from Shardj/zf1-future#278, Shardj/zf1-future#289 and Shardj/zf1-future#291 thanks @hungtrinh @glensc !
And added more fixes on top, which were not covered by the mentioned PRs.
Mitigate deprecation errors
Deprecated: Creation of dynamic property {x} is deprecated
which is thrown in php 8.2 and which are going to become fatal errors in php 9.php 8.2 requires all properties to be declared before using them.
https://php.watch/versions/8.2/dynamic-properties-deprecated
replaces #145 and #169
followup to allow dynamic props in
Zend_Form
,Zend_Form_Element
andZend_View_Abstract
➡ #180