Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zend-uri] update required and suggested deps according to usage #177

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[zend-uri] update required and suggested deps according to usage #177

merged 1 commit into from
Jan 3, 2024

Conversation

smhg
Copy link
Contributor

@smhg smhg commented Dec 17, 2023 •
edited by falkenhawk
Loading

This updates the dependencies of Zend_Uri to what I can find in the source. The findings:

  • Zend_Locale is never used (-require)
  • Zend_Date is never used (-suggest)
  • Zend_Registry is never used (-suggest)
  • Zend_Config is used in some circumstances (+suggest)

closes #175

falkenhawk
falkenhawk approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @smhg !

@falkenhawk falkenhawk merged commit 89ee503 into zf1s:master Jan 3, 2024
12 checks passed
@falkenhawk falkenhawk changed the title update required and suggested deps according to usage (closes #175) [zend-uri] update required and suggested deps according to usage Jan 3, 2024
@falkenhawk falkenhawk mentioned this pull request Jan 3, 2024
Closed
@smhg smhg deleted the fix-zend-uri-deps branch January 3, 2024 13:20
@falkenhawk falkenhawk mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkenhawk falkenhawk falkenhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary Zend_Uri dependencies
2 participants
@smhg @falkenhawk