Skip to content

Commit

Permalink
[Fix] Downgrade libsu to 5.1.0.
Browse files Browse the repository at this point in the history 
To fix regression on OnePlus devices.

Fixes: #1003
  • Loading branch information
@zhanghai
zhanghai committed Sep 3, 2023
1 parent 2354af0 commit dae309e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion app/build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ repositories {
dependencies {
implementation 'com.github.chrisbanes:PhotoView:2.3.0'
releaseImplementation 'com.github.mypplication:stetho-noop:1.1'
implementation 'com.github.topjohnwu.libsu:service:5.2.0'
// libsu 5.2.0 is buggy on OnePlus: https://github.com/topjohnwu/Magisk/issues/7214
//noinspection GradleDependency
implementation 'com.github.topjohnwu.libsu:service:5.1.0'
}

dependencies {
Expand Down

2 comments on commit dae309e

@pixincreate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libsu 5.2.1 seems to have fixed this regression issue

@zhanghai
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libsu 5.2.1 seems to have fixed this regression issue

Yes, I saw topjohnwu/Magisk#7214 (comment) as well.

Please sign in to comment.