Fix build on Nix 2.19+ #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bdafd64, as this workaround is no longer required on newer Nixpkgs.
winterqt
force-pushed
the
fix-build-on-newer-nix
branch
from
f01a221
to
b4bbb48
Compare
zhaofengli
force-pushed
the
fix-build-on-newer-nix
branch
from
b4bbb48
to
76f605f
Compare
Nix 2.19 introduced a change [0] that broke how we compile our libnixstore bindings, which requires adding an additional include directory when we compile them. [0]: NixOS/nix@b461cac
zhaofengli
force-pushed
the
fix-build-on-newer-nix
branch
from
76f605f
to
657db64
Compare
|
LGTM, thanks! Also added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix 2.19 introduced a change 0 that broke how we compile our libnixstore bindings, which requires adding an additional include directory when we compile them.
I also included a semi-related maintenance change that I had to apply when fixing this, let me know if you'd rather pull those in from a separate PR.