Skip to content

Commit

Permalink
fix .combine in seqParallel()
Browse files Browse the repository at this point in the history
  • Loading branch information
zhengxwen committed Mar 22, 2024
1 parent 5d54ce4 commit fe06cf8
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
7 changes: 7 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,18 @@ UTILITIES
o new `seqGetData(, "$dosage_alt2")` and `seqGetData(, "$dosage_sp2")` for
sex chromosomes, when the alleles are partially missing


CHANGES IN VERSION 1.42.3
-------------------------

BUG FIXES

o `seqGetData(, "$dosage_alt")` and `seqGetData(, "$dosage_sp")` work
correctly when the ploidy is >2 and there are missing alleles

o fix a bug that `seqParallel()` does not call a user-defined '.combine'
when 'parallel=1'


CHANGES IN VERSION 1.42.1
-------------------------
Expand Down
8 changes: 8 additions & 0 deletions R/Utilities.R
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,14 @@ seqParallel <- function(cl=seqGetParallel(), gdsfile, FUN,
ans <- FUN(gdsfile, ...)
}

if (is.function(.combine))
{
if (length(formals(args(.combine))) == 1L)
.combine(ans)
else
ans <- .combine(NULL, ans)
}

} else if (inherits(cl, "cluster"))
{
## multiple processes with a predefined cluster
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The SeqArray package is built on top of [Genomic Data Structure (GDS)](https://g

## Bioconductor:

Release Version: v1.42.1
Release Version: v1.42.3

[http://www.bioconductor.org/packages/release/bioc/html/SeqArray.html](http://www.bioconductor.org/packages/SeqArray)

Expand Down

0 comments on commit fe06cf8

Please sign in to comment.