Refactor poc methods and games #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current simple Q and MonteCarlo learners use inheritance to implement the game specific nuances that it's training. I'm not the biggest fan of inheritance and being able to compose the games along with the learners instead feels a lot cleaner. This branch is an attempt to do that. However, the result is a bit clumsy, so just leaving it in a branch for now.
I think it'd help to write out each use case. The current learners are the simple Q learner, Monte Carlo, and Alpha Zero. Each has slightly different usages of the games that it trains on, so it's tough to generalize everything, or at least, it would require more thought and planning.