Add missing Window bindings #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing GLFW bindings for window management functions, expanding the Zig wrapper's coverage of GLFW's window API. The bindings include window state management (iconify, restore, maximize, hide), opacity control, aspect ratio setting, frame size querying, and attention requests.
- Adds 10 new GLFW function bindings for window management operations
- Provides both direct function bindings and object-oriented method aliases on the Window struct
- Implements a helper method
getFrameSize()that returns window frame dimensions as an array
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+771
to
+774
| var left: c_int = 0.0; | ||
| var top: c_int = 0.0; | ||
| var right: c_int = 0.0; | ||
| var bottom: c_int = 0.0; |
There was a problem hiding this comment.
Integer variables are being initialized with floating-point literal 0.0. Use 0 instead of 0.0 for c_int variables.
Comment on lines
780
to
781
| var width: c_int = 0.0; | ||
| var height: c_int = 0.0; |
There was a problem hiding this comment.
Integer variables are being initialized with floating-point literal 0.0. Use 0 instead of 0.0 for c_int variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing bindings for the glfw functions:
glfwSetWindowAspectRatioglfwGetWindowFrameSizeglfwGetWindowOpacityglfwSetWindowOpacityglfwIconifyWindowglfwRestoreWindowglfwMaximizeWindowglfwHideWIndowglfwRequestWindowAttentionglfwPostEmptyEventAll functions except for
postEmptyEventhave been aliased as methods to theWindowstruct to support the "objecty" API.