compiler-rt: re-enable memcpy runtime safety in tests #22875
+156
−147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR re-enables runtime safety for compiler-rt
memcpy
tests. This should allow detecting logic bugs more reliably with tests.The diff looks messy due to indentation changes, but the only actual changes are the re-inclusion of 3 asserts that were removed in #22854 and making the implementation generic based on a comptime
enable_safety: bool
parameter. This allows the tests to test the logic withenable_safety == true
while not causing recursive calls tomemcpy
, as thememcpy
calls made by safety code will call the version withenable_safety == false
.Another option would have been to have
enable_safety
be a comptime argument to all the helper functions - this makes a cleaner diff, but I think it makes the code a bit harder to read.