Skip to content

Commit

Permalink
[milvus] add Deployment strategy configuration (#56)
Browse files Browse the repository at this point in the history
Signed-off-by: Jeremy Smadja <jeremy.smadja@adevinta.com>
  • Loading branch information
Archalbc authored Feb 27, 2024
1 parent e0bdb41 commit 75bc174
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 0 deletions.
4 changes: 4 additions & 0 deletions charts/milvus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ The following table lists the configurable parameters of the Milvus Proxy compon
| `proxy.http.enabled` | Enable rest api for Milvus Proxy | `true` |
| `proxy.http.debugMode.enabled` | Enable debug mode for rest api | `false` |
| `proxy.tls.enabled` | Enable porxy tls connection | `false` |
| `proxy.strategy` | Deployment strategy configuration | RollingUpdate |

### Milvus Root Coordinator Deployment Configuration

Expand Down Expand Up @@ -418,6 +419,7 @@ The following table lists the configurable parameters of the Milvus Query Node c
| `queryNode.disk.enabled` | Whether to enable disk for query | `true` |
| `queryNode.profiling.enabled` | Whether to enable live profiling | `false` |
| `queryNode.extraEnv` | Additional Milvus Query Node container environment variables | `[]` |
| `queryNode.strategy` | Deployment strategy configuration | RollingUpdate |

### Milvus Index Coordinator Deployment Configuration

Expand Down Expand Up @@ -459,6 +461,7 @@ The following table lists the configurable parameters of the Milvus Index Node c
| `indexNode.disk.enabled` | Whether to enable disk for index node | `true` |
| `indexNode.profiling.enabled` | Whether to enable live profiling | `false` |
| `indexNode.extraEnv` | Additional Milvus Index Node container environment variables | `[]` |
| `indexNode.strategy` | Deployment strategy configuration | RollingUpdate |

### Milvus Data Coordinator Deployment Configuration

Expand Down Expand Up @@ -499,6 +502,7 @@ The following table lists the configurable parameters of the Milvus Data Node co
| `dataNode.heaptrack.enabled` | Whether to enable heaptrack | `false` |
| `dataNode.profiling.enabled` | Whether to enable live profiling | `false` |
| `dataNode.extraEnv` | Additional Milvus Data Node container environment variables | `[]` |
| `dataNode.strategy` | Deployment strategy configuration | RollingUpdate |

### Milvus Mixture Coordinator Deployment Configuration

Expand Down
4 changes: 4 additions & 0 deletions charts/milvus/templates/datanode-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ spec:
{{- if ge (int .Values.dataNode.replicas) 0 }}
replicas: {{ .Values.dataNode.replicas }}
{{- end }}
{{- with .Values.dataNode.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
{{- end }}
selector:
matchLabels:
{{ include "milvus.matchLabels" . | indent 6 }}
Expand Down
4 changes: 4 additions & 0 deletions charts/milvus/templates/indexnode-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ spec:
{{- if ge (int .Values.indexNode.replicas) 0 }}
replicas: {{ .Values.indexNode.replicas }}
{{- end }}
{{- with .Values.indexNode.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
{{- end }}
selector:
matchLabels:
{{ include "milvus.matchLabels" . | indent 6 }}
Expand Down
4 changes: 4 additions & 0 deletions charts/milvus/templates/proxy-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ spec:
{{- if ge (int .Values.proxy.replicas) 0 }}
replicas: {{ .Values.proxy.replicas }}
{{- end }}
{{- with .Values.proxy.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
{{- end }}
selector:
matchLabels:
{{ include "milvus.matchLabels" . | indent 6 }}
Expand Down
4 changes: 4 additions & 0 deletions charts/milvus/templates/querynode-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ spec:
{{- if ge (int .Values.queryNode.replicas) 0 }}
replicas: {{ .Values.queryNode.replicas }}
{{- end }}
{{- with .Values.queryNode.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
{{- end }}
selector:
matchLabels:
{{ include "milvus.matchLabels" . | indent 6 }}
Expand Down
12 changes: 12 additions & 0 deletions charts/milvus/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,9 @@ proxy:
# volumeMounts:
# - mountPath: /etc/milvus/certs/
# name: milvus-tls
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}

rootCoordinator:
enabled: true
Expand Down Expand Up @@ -319,6 +322,9 @@ queryNode:
enabled: false # Enable local storage size limit
profiling:
enabled: false # Enable live profiling
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}

indexCoordinator:
enabled: true
Expand Down Expand Up @@ -362,6 +368,9 @@ indexNode:
enabled: true # Enable index node build disk vector index
size:
enabled: false # Enable local storage size limit
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}

dataCoordinator:
enabled: true
Expand Down Expand Up @@ -398,6 +407,9 @@ dataNode:
enabled: false
profiling:
enabled: false # Enable live profiling
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}

## mixCoordinator contains all coord
## If you want to use mixcoord, enable this and disable all of other coords
Expand Down

0 comments on commit 75bc174

Please sign in to comment.