Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milvus-4.1.18] Enhancement: Configurable User limit settings for Milvus #63

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

Rachit-Chaudhary11
Copy link
Contributor

Author - @Rachit-Chaudhary11

What this PR does / why we need it:

This update will allow for better scalability and flexibility in managing the users access to milvus instance. Presently this limit is set to 100 users per milvus instance and there is no way to increase / decrease the users limit to milvus instance.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@Rachit-Chaudhary11
Copy link
Contributor Author

/assign @zwd1208
Please validate the pull request.

@haorenfsa
Copy link
Collaborator

@Rachit-Chaudhary11 Please also sign-off this commit. And you may also need to rebase after the last PR is merged, and make sure the Chart Version is bumped.
same as I mentioned in #61 (comment)

Signed-off-by: Rachit Chaudhary - r0c0axe <Rachit.Chaudhary@walmart.com>
@haorenfsa
Copy link
Collaborator

/lgtm

@haorenfsa
Copy link
Collaborator

@Rachit-Chaudhary11 We bump the chart version in every PR.
So please rebase master branch again, and bump the chart version to 4.1.21. Thank you very much.

@mergify mergify bot added the ci-passed label Feb 26, 2024
Rachit Chaudhary - r0c0axe added 2 commits February 26, 2024 17:09
Signed-off-by: Rachit Chaudhary - r0c0axe <Rachit.Chaudhary@walmart.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Feb 26, 2024
@mergify mergify bot removed the ci-passed label Feb 26, 2024
@Rachit-Chaudhary11
Copy link
Contributor Author

@haorenfsa please check, I have bumped up the milvus chart version

@mergify mergify bot added the ci-passed label Feb 26, 2024
@Rachit-Chaudhary11
Copy link
Contributor Author

/assign @zwd1208
@haorenfsa Please validate the pull request.

@haorenfsa
Copy link
Collaborator

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Rachit-Chaudhary11

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e0bdb41 into zilliztech:master Feb 27, 2024
5 checks passed
@Rachit-Chaudhary11 Rachit-Chaudhary11 changed the title [milvus-4.1.18] Enhancement: Reset Default Max Limit on Users per Milvus Instance [milvus-4.1.18] Enhancement: Configurable Users limit for Milvus Feb 27, 2024
@Rachit-Chaudhary11 Rachit-Chaudhary11 changed the title [milvus-4.1.18] Enhancement: Configurable Users limit for Milvus [milvus-4.1.18] Enhancement: Configurable User limit settings for Milvus Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants