Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥗🧹 Journal: Entry stores each Keyword it uses only once. #1675

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Jul 15, 2023

Turns out we were storing the keyword every time it was used; which... isn't bad but isn't great either!

@zspencer zspencer requested review from a team July 15, 2023 02:08
@zspencer zspencer changed the title Journal: Entry stores each Keyword it uses only once. 🥗🧹 Journal: Entry stores each Keyword it uses only once. Jul 15, 2023
@zspencer zspencer added 🥗 test automation Adds some automated tests. V nutritious. 🧹 refactor Includes non-behavioral changes labels Jul 15, 2023
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@zspencer zspencer merged commit a6c4d02 into main Jul 20, 2023
@zspencer zspencer deleted the journal/keywords-are-unique branch July 20, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 refactor Includes non-behavioral changes 🥗 test automation Adds some automated tests. V nutritious.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants