Enhance Docker Configuration #701
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianlujan
changed the title
sebastianlujan
changed the title
juanky201271
requested changes
Sep 20, 2024
| @@ -4,3 +4,4 @@ distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-all.zip | |||
| networkTimeout=10000 | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| /home/sebas/Android/Sdk | |||
There was a problem hiding this comment.
I think you need to remove this...
| @@ -84,7 +84,7 @@ module.exports = { | |||
| }, | |||
| 'android.emu.x86_64': { | |||
| device: 'emulator_x86_64', | |||
| app: 'android.debug' | |||
| app: 'Pixel_2_API_30' | |||
There was a problem hiding this comment.
We need this? the user have to have this specific device in the local env.... mmmm, I don't think so.
| @@ -23,6 +23,6 @@ WHO PAYS? | |||
| At this time seednode.link is paid for and maintained by operating volunteers. In the future, addresses for contribution to keep the project going may be published. | |||
|
|
|||
| MORE? | |||
| Radicle official project chat: https://radicle.zulipchat.com | |||
| Radicle official project chat: htt_test_ps://radicle.zulipchat.com | |||
| @@ -21,8 +21,7 @@ until [[ $step_complete == true ]]; do | |||
| echo "Error: Failed to install APKs" >&2 | |||
| echo "For more information see '${output_dir}/emulator_install_apk.txt'" >&2 | |||
| exit 1 | |||
| fi | |||
| fiTHE | |||
| @@ -10,4 +10,5 @@ cd $(git rev-parse --show-toplevel) | |||
|
|
|||
| ./scripts/flow_emulator_setup.sh $@ | |||
|
|
|||
| ./scripts/flow_emulate_interactive.sh | |||
| ./scripts/flow_emulate_interactive.sh "start": "react-native start", | |||
There was a problem hiding this comment.
I don't see the point of this.... some copy-paste mistake, maybe...
| @@ -45,6 +45,7 @@ | |||
| "patch-package": "^6.5.1", | |||
| "postinstall-postinstall": "^2.1.0", | |||
| "prop-types": "^15.8.1", | |||
| "punycode": "^2.3.1", | |||
There was a problem hiding this comment.
Where or Why are you using this library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
Modified .detoxrc.js: Adjusted emulator settings.
Added Dockerfile: Introduced a Dockerfile for environment setup.
Added .dockerignore: Prevented unnecessary files from being included in Docker images.
Updated gradle.properties: Enabled parallel execution for improved build performance.