fix(graphql): add query timeout argument when create client. #1447
Conversation
|
I needed this functionality, what is the release plan for this ? 🙏 |
|
@vincenzopalazzo |
# Conflicts: # packages/graphql/lib/src/core/query_manager.dart # packages/graphql/lib/src/graphql_client.dart
ykuc7
force-pushed
the
fix-add-timeout-argument-to-create-client
branch
from
1b52d19
to
6180841
Compare
|
@vincenzopalazzo |
|
any chance we could have the argument as optional? e.g. we prefer to let server handle the timeout and let the client library remain as it was before this change :) |
|
@uri-ravzin PR are welcome if you add a good justification on why you need it optional |
We like to let the server handle the timeout. (as it was in older versions here as well) short timeouts can lead to repeated requests, unexpected results, and actually increased load on the server, by users who just want to have their requests to complete. Specifically in our product, we like the upgrades and are fast adopters to all beta releases, but currently seem to be stuck on 5.2.0-beta.7 due to this new introduced mandatory parameter. |
Enhancements