-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
override private[actors] val actorSystemName: String, | ||
override private[actors] val config: Option[String], | ||
private val remoteConfig: Option[RemoteConfig], | ||
private val initActorRefMap: Ref[Map[String, Actor[Any]]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I see it correctly the only version-specific difference is Actor[Any]
vs Actor[?]
here. Is Scala 2 not compiling with ?
(or _
?)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, I have made a few attempts on scala 2.13 but haven't been able to make it work... Get errors like:
private val initActorRefMap: Ref[Map[String, Actor[_]]], _$2 takes no type parameters, expected: 1
^
I have also tried to make scala 3 compile with Actor[Any]
but get errors like:
Type argument Any does not have the same kind as its bound [+_$1]
Is this update supposed to be launch soon? |
When will this update be released? |
If you are waiting for it I think the best course of action is to go into the zio discord and ask if someone can release it for you since this library is unmaintained. I had to go there to get someone to review my code. |
Hello! 👋
I really want to use zio-actors for a toy project and thought this could become a good first open source contribution:)
This PR is first and foremost to get zio-actors to build on scala 3. I tried to (almost) only make changes that would make the project compile on Scala 3 and solve issue #308. Below is a summary of the changes I made:
scala-reflect
(dropped in Scala 3)Migrated minor syntax things like imports (._ to .*) and wildcard types [_] to [?]import foo._
)PendingMessage[F[_],A]
type (migration notes)AkkaTypedActorRefLocal
needed a type parameter, it is not how akka does it, we don't use it and it was hard to make it work on scala 3...Happy new year!🎉Edit:
I'm trying to look at the zio-http project but I'm not familiar with this kind of sbt. I will see if I can get it to compile on all platforms(Made it!)