Skip to content

Conversation

@Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Oct 29, 2025

Fix some import and also weird code

Related to #386

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Its-Just-Nans, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on internal code hygiene and consistency by refactoring various import statements across the crate. It transitions several standard library dependencies to their core counterparts and ensures that file system operations like create_dir_all are explicitly imported at the function level, leading to a more modular and potentially more portable codebase.

Highlights

  • Import Refactoring: Several standard library imports (e.g., std::mem, std::ops, std::default, std::fmt, std::marker, std::str) have been refactored to use their core equivalents, promoting consistency and potential no_std compatibility.
  • Explicit fs::create_dir_all Usage: The create_dir_all function from std::fs is now explicitly imported within the function scope where it is used, rather than being a global import, improving local dependency clarity.
  • Qualified size_of Calls: All instances of size_of have been updated to mem::size_of to explicitly reference the function from the core::mem module, aligning with the import refactoring.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors imports across several files, primarily moving them from std to core where possible, making re-exports more explicit, and scoping filesystem-related imports more locally. These are all positive changes for code clarity and potential no_std compatibility. My main feedback is to improve consistency in how size_of is imported and used. Also, a more descriptive PR title, like 'refactor: Clean up imports and prefer core over std', would better follow the Conventional Commits standard mentioned in your contribution guidelines.

@Its-Just-Nans Its-Just-Nans changed the title fix some import refactor: Clean up imports and move types Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant