Conversation
Document the missing public API items from mcp::analytics module: - TraitDefinition struct with all fields - ebv_glossary() function with usage example These items are public exports from crates/mcp/analytics.rs but were not previously documented in the Library API Reference. Cross-reference to MCP.md for the complete trait glossary table. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 9 9
Lines 6499 6499
=======================================
Hits 6228 6228
Misses 271 271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Code Coverage ReportOverall Coverage: 0% SummaryFull HTML report available in CI artifacts. |
There was a problem hiding this comment.
Pull request overview
This PR adds complete API reference documentation for the TraitDefinition struct and ebv_glossary() function in the mcp::analytics module, closing a documentation gap for public API items that were previously undocumented.
Changes:
- Documents the
TraitDefinitionstruct with all five fields and their types - Documents the
ebv_glossary()function with signature, description, and usage example - Adds cross-reference to the complete trait table in MCP.md
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing public API documentation for
mcp::analyticsmodule items that were not previously documented in the Library API Reference.Changes
Added documentation for two public items from
crates/mcp/analytics.rs:TraitDefinitionstruct&'static str)ebv_glossary()functionMCP.md#ebv-trait-glossaryDocumentation Quality
LIBRARY-API.md(field tables, code examples, cross-references)mcp::analyticsare now documentedcrates/mcp/analytics.rs:266-281Testing
mcp::analyticsverified as documented#ebv-trait-glossaryexists in MCP.md)Related
Complements recent PR #79 which added comprehensive MCP module documentation.
Documentation gap identified: These public exports were accessible via
use nsip::mcp::analytics::{TraitDefinition, ebv_glossary};but were undocumented in the reference manual.