Skip to content

perf(.claude): sync agents and spec-orchestrator from rust-template#89

Closed
zircote wants to merge 3 commits intomainfrom
chore/sync-claude-agents
Closed

perf(.claude): sync agents and spec-orchestrator from rust-template#89
zircote wants to merge 3 commits intomainfrom
chore/sync-claude-agents

Conversation

@zircote
Copy link
Owner

@zircote zircote commented Feb 22, 2026

Summary

  • Add team coordination tools (SendMessage, TaskList, TaskGet, TaskUpdate) to all agents
  • Add spec-orchestrator command with lifecycle fixes
  • Sync from rust-template

Files

  • .claude/agents/code-reviewer.md — updated tools
  • .claude/agents/rust-developer.md — updated tools
  • .claude/agents/test-engineer.md — updated tools
  • .claude/commands/spec-orchestrator.md — new command

- Add team coordination tools to all agents
- Update spec-orchestrator command with lifecycle fixes
@github-actions
Copy link
Contributor

Benchmark Results

No benchmarks configured. Add benchmarks to benches/ directory.

Full results available in CI artifacts.

@github-actions
Copy link
Contributor

Benchmark Results

No benchmarks configured. Add benchmarks to benches/ directory.

Full results available in CI artifacts.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.83%. Comparing base (bb2f81c) to head (1f7d395).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files           9        9           
  Lines        6499     6499           
=======================================
  Hits         6228     6228           
  Misses        271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Code Coverage Report

Overall Coverage: 0%

Summary

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
client.rs                        1444                67    95.36%         118                13    88.98%         923                35    96.21%           0                 0         -
format.rs                        2172                 3    99.86%         132                 1    99.24%        1292                 1    99.92%           0                 0         -
main.rs                           326               241    26.07%          14                 8    42.86%         225               168    25.33%           0                 0         -
mcp/analytics.rs                  408                 2    99.51%          24                 0   100.00%         331                 0   100.00%           0                 0         -
mcp/mod.rs                        144                55    61.81%          23                15    34.78%         128                65    49.22%           0                 0         -
mcp/prompts.rs                   1908                33    98.27%         126                 6    95.24%        1043                12    98.85%           0                 0         -
mcp/resources.rs                 1317                20    98.48%          93                 1    98.92%         865                 6    99.31%           0                 0         -
mcp/tools.rs                     2146                90    95.81%         116                18    84.48%        1333                47    96.47%           0                 0         -
models.rs                        1079                31    97.13%          78                10    87.18%         762                14    98.16%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                           10944               542    95.05%         724                72    90.06%        6902               348    94.96%           0                 0         -

Full HTML report available in CI artifacts.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs .claude automation assets from rust-template, expanding agent coordination capabilities and introducing a new spec-orchestrator command for parallel, wave-based spec implementation.

Changes:

  • Added team coordination tools (e.g., SendMessage, TaskList, TaskGet, TaskUpdate) to the existing .claude/agents/* definitions.
  • Added a new .claude/commands/spec-orchestrator.md command that formalizes discovery → planning → execution → verification → cleanup for large specs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
.claude/commands/spec-orchestrator.md New orchestration command with task/team lifecycle, wave execution, and verification guidance.
.claude/agents/code-reviewer.md Expanded tool list to support coordination/task operations.
.claude/agents/rust-developer.md Expanded tool list to support coordination/task operations.
.claude/agents/test-engineer.md Expanded tool list to support coordination/task operations.
Comments suppressed due to low confidence (6)

.claude/commands/spec-orchestrator.md:503

  • cargo test --all runs all workspace packages but does not enable all features; this repo’s documented command is cargo test --all-features (or just test). Using --all here may miss feature-gated code and diverge from CI expectations.
```bash
cargo test --all 2>&1
**.claude/commands/spec-orchestrator.md:399**
* `spec-orchestrator` requires teammate agents to have `TaskCreate` in their tool list and claims the `rust-developer` agent includes it, but `.claude/agents/rust-developer.md` currently does not. This inconsistency can cause confusion (and potentially orchestration failures if the tool list is validated). Either add `TaskCreate` to the rust-developer agent tools, or update this requirement text to match the actual coordination tools needed (likely `SendMessage`, `TaskList`, `TaskGet`, `TaskUpdate`).
  1. Teammate agent types MUST have team coordination tools (SendMessage, TaskList, TaskGet, TaskCreate, TaskUpdate) in their tool list. The rust-developer agent includes these. If using a custom agent, verify its tools first.
**.claude/commands/spec-orchestrator.md:586**
* The orchestrator rules state teammate agents need `TaskCreate` and that `rust-developer` includes it, but `rust-developer` (and `test-engineer`) currently lack `TaskCreate` in their `tools:` list. Align the rules with the actual agent capabilities, or update the agent tool lists so this statement is true.
  1. Teammate agent types MUST include team coordination tools — Any agent used as a teammate needs SendMessage, TaskList, TaskGet, TaskCreate, TaskUpdate in its tool list. The rust-developer agent includes these. If using a custom agent, verify its tools first. Teammates are spawned via Task with team_name, name, and run_in_background: true.
  2. Teammates self-claim tasks — Teammates find unblocked unclaimed tasks via TaskList and claim them with TaskUpdate(owner). This is more resilient than leader-assignment.
**.claude/agents/rust-developer.md:6**
* If `spec-orchestrator` expects `rust-developer` teammates to have `TaskCreate` available (it currently claims they do), add `TaskCreate` to this agent's `tools:` list; otherwise, update the orchestrator documentation to not require it. Right now the agent definition and orchestrator requirements are inconsistent.

tools: Read, Write, Edit, Bash, Glob, Grep, LSP, SendMessage, TaskList, TaskGet, TaskUpdate

**.claude/agents/test-engineer.md:6**
* `spec-orchestrator` documentation states teammate agents need `TaskCreate` in their tool list, but this agent definition does not include it. Either add `TaskCreate` here (if test-engineer might be used as a teammate) or adjust the orchestrator text so it matches the intended coordination tool set.

tools: Read, Write, Edit, Bash, Glob, Grep, LSP, SendMessage, TaskList, TaskGet, TaskUpdate

**.claude/commands/spec-orchestrator.md:426**
* The repo’s documented lint command is `cargo clippy --all-targets --all-features -- -D warnings` (and `just lint`/`just check`), but the teammate checklist here uses `cargo clippy -- -D warnings` which may miss targets/features and lead to CI failures. Align this with CLAUDE.md’s commands (e.g., use `just lint` or the full clippy invocation).
1. Run `cargo fmt && cargo clippy -- -D warnings` via Bash
2. Mark done: TaskUpdate(taskId, status: "completed")
</details>

Custom agent types do not function as agent team teammates.
Sync spec-orchestrator command and justfile from rust-template.
@github-actions
Copy link
Contributor

Benchmark Results

No benchmarks configured. Add benchmarks to benches/ directory.

Full results available in CI artifacts.

@github-actions
Copy link
Contributor

Code Coverage Report

Overall Coverage: 0%

Summary

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
client.rs                        1444                67    95.36%         118                13    88.98%         923                35    96.21%           0                 0         -
format.rs                        2172                 3    99.86%         132                 1    99.24%        1292                 1    99.92%           0                 0         -
main.rs                           326               241    26.07%          14                 8    42.86%         225               168    25.33%           0                 0         -
mcp/analytics.rs                  408                 2    99.51%          24                 0   100.00%         331                 0   100.00%           0                 0         -
mcp/mod.rs                        144                55    61.81%          23                15    34.78%         128                65    49.22%           0                 0         -
mcp/prompts.rs                   1908                33    98.27%         126                 6    95.24%        1043                12    98.85%           0                 0         -
mcp/resources.rs                 1317                20    98.48%          93                 1    98.92%         865                 6    99.31%           0                 0         -
mcp/tools.rs                     2146                90    95.81%         116                18    84.48%        1333                47    96.47%           0                 0         -
models.rs                        1079                31    97.13%          78                10    87.18%         762                14    98.16%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                           10944               542    95.05%         724                72    90.06%        6902               348    94.96%           0                 0         -

Full HTML report available in CI artifacts.

@zircote zircote closed this Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants