perf(.claude): sync agents and spec-orchestrator from rust-template#89
perf(.claude): sync agents and spec-orchestrator from rust-template#89
Conversation
- Add team coordination tools to all agents - Update spec-orchestrator command with lifecycle fixes
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 9 9
Lines 6499 6499
=======================================
Hits 6228 6228
Misses 271 271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code Coverage ReportOverall Coverage: 0% SummaryFull HTML report available in CI artifacts. |
There was a problem hiding this comment.
Pull request overview
This PR syncs .claude automation assets from rust-template, expanding agent coordination capabilities and introducing a new spec-orchestrator command for parallel, wave-based spec implementation.
Changes:
- Added team coordination tools (e.g.,
SendMessage,TaskList,TaskGet,TaskUpdate) to the existing.claude/agents/*definitions. - Added a new
.claude/commands/spec-orchestrator.mdcommand that formalizes discovery → planning → execution → verification → cleanup for large specs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.claude/commands/spec-orchestrator.md |
New orchestration command with task/team lifecycle, wave execution, and verification guidance. |
.claude/agents/code-reviewer.md |
Expanded tool list to support coordination/task operations. |
.claude/agents/rust-developer.md |
Expanded tool list to support coordination/task operations. |
.claude/agents/test-engineer.md |
Expanded tool list to support coordination/task operations. |
Comments suppressed due to low confidence (6)
.claude/commands/spec-orchestrator.md:503
cargo test --allruns all workspace packages but does not enable all features; this repo’s documented command iscargo test --all-features(orjust test). Using--allhere may miss feature-gated code and diverge from CI expectations.
```bash
cargo test --all 2>&1
**.claude/commands/spec-orchestrator.md:399**
* `spec-orchestrator` requires teammate agents to have `TaskCreate` in their tool list and claims the `rust-developer` agent includes it, but `.claude/agents/rust-developer.md` currently does not. This inconsistency can cause confusion (and potentially orchestration failures if the tool list is validated). Either add `TaskCreate` to the rust-developer agent tools, or update this requirement text to match the actual coordination tools needed (likely `SendMessage`, `TaskList`, `TaskGet`, `TaskUpdate`).
- Teammate agent types MUST have team coordination tools (
SendMessage,TaskList,TaskGet,TaskCreate,TaskUpdate) in their tool list. Therust-developeragent includes these. If using a custom agent, verify its tools first.
**.claude/commands/spec-orchestrator.md:586**
* The orchestrator rules state teammate agents need `TaskCreate` and that `rust-developer` includes it, but `rust-developer` (and `test-engineer`) currently lack `TaskCreate` in their `tools:` list. Align the rules with the actual agent capabilities, or update the agent tool lists so this statement is true.
- Teammate agent types MUST include team coordination tools — Any agent used as a teammate needs
SendMessage,TaskList,TaskGet,TaskCreate,TaskUpdatein its tool list. Therust-developeragent includes these. If using a custom agent, verify its tools first. Teammates are spawned viaTaskwithteam_name,name, andrun_in_background: true. - Teammates self-claim tasks — Teammates find unblocked unclaimed tasks via
TaskListand claim them withTaskUpdate(owner). This is more resilient than leader-assignment.
**.claude/agents/rust-developer.md:6**
* If `spec-orchestrator` expects `rust-developer` teammates to have `TaskCreate` available (it currently claims they do), add `TaskCreate` to this agent's `tools:` list; otherwise, update the orchestrator documentation to not require it. Right now the agent definition and orchestrator requirements are inconsistent.
tools: Read, Write, Edit, Bash, Glob, Grep, LSP, SendMessage, TaskList, TaskGet, TaskUpdate
**.claude/agents/test-engineer.md:6**
* `spec-orchestrator` documentation states teammate agents need `TaskCreate` in their tool list, but this agent definition does not include it. Either add `TaskCreate` here (if test-engineer might be used as a teammate) or adjust the orchestrator text so it matches the intended coordination tool set.
tools: Read, Write, Edit, Bash, Glob, Grep, LSP, SendMessage, TaskList, TaskGet, TaskUpdate
**.claude/commands/spec-orchestrator.md:426**
* The repo’s documented lint command is `cargo clippy --all-targets --all-features -- -D warnings` (and `just lint`/`just check`), but the teammate checklist here uses `cargo clippy -- -D warnings` which may miss targets/features and lead to CI failures. Align this with CLAUDE.md’s commands (e.g., use `just lint` or the full clippy invocation).
1. Run `cargo fmt && cargo clippy -- -D warnings` via Bash
2. Mark done: TaskUpdate(taskId, status: "completed")
</details>
Custom agent types do not function as agent team teammates. Sync spec-orchestrator command and justfile from rust-template.
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Code Coverage ReportOverall Coverage: 0% SummaryFull HTML report available in CI artifacts. |
Summary
Files
.claude/agents/code-reviewer.md— updated tools.claude/agents/rust-developer.md— updated tools.claude/agents/test-engineer.md— updated tools.claude/commands/spec-orchestrator.md— new command