Skip to content

fix(ci): harden package-homebrew version extraction and SHA validation #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zircote merged 2 commits into from
Feb 22, 2026
Merged

fix(ci): harden package-homebrew version extraction and SHA validation #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427a2e1
Initial plan
Copilot Feb 22, 2026
0ac9be8
fix(ci): apply review feedback to package-homebrew.yml
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions .github/workflows/package-homebrew.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,21 @@ jobs:
REPO: ${{ github.repository }}
run: |
if [ "$EVENT_NAME" = "workflow_run" ]; then
VERSION="${RUN_HEAD_BRANCH#v}"
# Expect RUN_HEAD_BRANCH to be a tag like "v1.2.3"
if printf '%s\n' "$RUN_HEAD_BRANCH" | grep -Eq '^v[0-9]+\.[0-9]+\.[0-9]+([0-9A-Za-z.+-]*)?$'; then
VERSION="${RUN_HEAD_BRANCH#v}"
else
echo "Error: workflow_run triggered from non-tag ref '$RUN_HEAD_BRANCH'. Expected a tag like 'v1.2.3'." >&2
exit 1
fi
else
VERSION="$INPUT_VERSION"
# Normalize INPUT_VERSION by stripping optional leading "v"
RAW_VERSION="${INPUT_VERSION#v}"
if ! printf '%s\n' "$RAW_VERSION" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+([0-9A-Za-z.+-]*)?$'; then
echo "Error: Provided version '$INPUT_VERSION' is not a valid semantic version (e.g., 1.2.3)." >&2
exit 1
fi
VERSION="$RAW_VERSION"
fi
echo "version=$VERSION" >> "$GITHUB_OUTPUT"

Expand Down Expand Up @@ -81,11 +93,11 @@ jobs:
SRC_SHA=$(curl -sL "$SRC_URL" \
| shasum -a 256 | awk '{print $1}')

# Verify all SHAs are unique (identical = failed downloads)
SHAS="$ARM64_SHA $AMD64_SHA $LINUX_SHA"
UNIQUE=$(echo "$SHAS" | tr ' ' '\n' | sort -u | wc -l)
if [ "$UNIQUE" -lt 3 ]; then
echo "::error::SHA mismatch: binary SHAs are not unique."
# Verify all asset SHAs are unique (identical = failed downloads)
SHAS="$ARM64_SHA $AMD64_SHA $LINUX_SHA $COMP_SHA $MAN_SHA $SRC_SHA"
UNIQUE=$(echo "$SHAS" | tr ' ' '\n' | sort -u | grep -c .)
if [ "$UNIQUE" -lt 6 ]; then
echo "::error::SHA mismatch: asset SHAs are not unique."
echo " Assets may not have been uploaded yet."
exit 1
fi
Expand Down