feat(op): PKCE Verification in Legacy Server when AuthMethod is not NONE and CodeVerifier is not Empty #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… None, and code verifier is not empty.
andar1an
commented
Dec 5, 2023
muhlemmer
approved these changes
Dec 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 60.39% 60.51% +0.11%
==========================================
Files 78 78
Lines 6797 6797
==========================================
+ Hits 4105 4113 +8
+ Misses 2397 2386 -11
- Partials 295 298 +3 ☔ View full report in Codecov by Sentry. |
muhlemmer
changed the title
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue 254 and Issue 6886
Authorization Code + PKCE is the most secure and commonly recommended authentication method when referencing many Social Providers and IDP's.
This change is primarily to enable PKCE verification when using Code method - how this will be implemented will be determined internally by Zitadel team (e.g. an option in current method, or a new method a user can choose).
Definition of Ready