Internal links on site head

[spi43984]

I needed some links on the cover page to link to internal sites and not showing the leading fork awesome icon.
For some of these pages I also wanted to get the content still rendered on the homepage - for others not.

With these changes two parameters are introduced in the markdown files:
internal = the URL to link to
internal_hide = if true then do not render this markdown file (as a side-effect this works on all homepage markdown files to show or hide them)

[zjedi]

Something seems wrong with the demo page, see deployed demo, at the very bottom. https://deploy-preview-158--hugo-scroll.netlify.app/#github

[netlify]

Comment has been resolved

spi left a comment:

Try to join the review on Netlify regarding issue #158
Cheers
spi

Browser metadata

Path:      /#github
Browser:   Chrome 117.0.0.0 on Linux x86_64
Viewport:  1720 x 1267 @1x
Language:  de-DE
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Unresolved

[spi43984]

Something seems wrong with the demo page, see deployed demo, at the very bottom. https://deploy-preview-158--hugo-scroll.netlify.app/#github

Added leading '---' to internal.md.

Seems to work now - just the contacts button on the cover page leads to nowhere as the destination is missing. Will create a demo page...

checked the demo, found issues

[zjedi]

@spi43984 If you go check the demo now, there are some outstanding issues

• two sections Contact + Contacts, sounds illogical to have two of them
• try navigating from landing page, from left "sticky menu", play around, I managed to run into an error.

[spi43984]

@spi43984 If you go check the demo now, there are some outstanding issues

• two sections Contact + Contacts, sounds illogical to have two of them

fair point - as there is already a contact section, will prepare another example, maybe legal or something

• try navigating from landing page, from left "sticky menu", play around, I managed to run into an error.

What was the error? Can you please give some more context?
Or is it GITHUB to show up in the nav menu? Which should not as it is an external link, found a bug in index.html - am trying to solve that:

{{ $content := where $sections "Params.external" "==" nil }}
{{ $content := where $sections "Params.internal_hide" "ne" true }}

The second line circumvents the first one and renders homepage content even it is an external link.

Is there a combination possible like

{{ $content := where $sections and ("Params.internal_hide" "ne" true) ("Params.internal_hide" "ne" true) }}

Edit:

{{ $content := where (where $sections "Params.external" "==" nil) "Params.internal_hide" "ne" true }}

seems to do the trick...

[spi43984]

@spi43984 If you go check the demo now, there are some outstanding issues

• two sections Contact + Contacts, sounds illogical to have two of them
• try navigating from landing page, from left "sticky menu", play around, I managed to run into an error.

please review

[zjedi]

two sections Contact + Contacts, sounds illogical to have two of them

Looks good now, thanks!

try navigating from landing page, from left "sticky menu", play around, I managed to run into an error.

Unable to reproduce the error, looks ok now.

[zjedi]

Looks good, just a couple suggestions regarding configuration property names to make them more obvious :)