fix: issues in passkey flow #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses minor issues in the passkey flow and updates the UI text and account handling during the passkey and EIP-7702 workflow.
- Updated account creation logic and dependency management in the safe flow page.
- Refined state handling and updated UI text in recovery and entry components.
- Modified environment variable handling in auth and error messaging in the server entry file.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/EOA7702SafeFlow.tsx | Updated creation of burner account and wallet client integration. |
| src/components/eoa7702Wallet/auth.ts | Removed default fallback for RELAYER_PRIVATE_KEY to rely on env. |
| src/components/eoa7702Wallet/RequestedRecoveries.tsx | Replaced owner account state with ownerPasskeyAccount and updated recovery cancellation flow. |
| src/components/eoa7702Wallet/GuardianSetup.tsx | Added additional informational text for guardian setup status. |
| src/components/eoa7702Wallet/EOA7702Entry.tsx | Updated account reference and refined instructional text for wallet upgrade. |
| server.js | Adjusted the fatal error logging message format. |
Comments suppressed due to low confidence (1)
src/components/eoa7702Wallet/RequestedRecoveries.tsx:465
- Correct the spelling 'Reciept' to 'Receipt' in the log message for clarity.
console.log("User Operation Reciept:", userOpReciept);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed some of the minor issue in the workflow and edits the description shown during the passkey<->7702 flow
ref: #17