Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maimaidx] Update to BUDDiES PLUS final #1187

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[maimaidx] Update to BUDDiES PLUS final #1187

merged 2 commits into from
Oct 1, 2024

Conversation

beer-psi
Copy link
Contributor

  • Added all songs up to BUDDiES PLUS
  • Added version BUDDiES PLUS Omnimix, marking BUDDiES Omnimix as inactive

@tachi-repo-bot
Copy link

A commit has changed the seeds. View the diff here.

zkrising
zkrising reviewed Oct 1, 2024
View reviewed changes
seeds/scripts/rerunners/maimaidx/merge-options.ts

// fast-xml-parser will coerce anything that looks like a number into a
// number, so the song "39" will be converted into a number.
str: string | number;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

zkrising
zkrising approved these changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@zkrising zkrising left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Glad to see you caught that fast-xml-parser bit of nonsense.

@zkrising zkrising merged commit 7d28542 into zkrising:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkrising zkrising zkrising approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beer-psi @zkrising