feat: arcaea support #951
Merged
feat: arcaea support #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i messed up with sdvx
Futureproofing for when someone wants to add support for the Nintendo Switch version of the game.
The default formatter should work fine for Arcaea scores
whatever you wanna call it.
Course banner more closely matches the game, since there's not a single mention of the word dan in it.
more futureproofing for arcaea switch support. also adds gauge percentage to the lamp cell.
It turns out that Arcaea's implementation of gauge is intensely stupid, because the maximum gauge value is based on which partner is selected (e.g. Toa Kozukata's max gauge is 60). It's rare that anyone would care about the remaining life at the end of the chart anyways, unless it's something like a 0-gauge HARD CLEAR.
|
marking this as ready for review @beerpiss should have a very basic way of pulling data from the game readily available |
|
this'll go on bokutachi jsyk |
|
actually i'm rather interested on why, because arcaea by itself is very similar to the arcade rhythm games available on kamaitachi i don't have a problem with it being on either instances though |
|
bokutachi is for games you can play at home and kamaitachi is for arcade games |
|
sounds good to me honestly |
|
will review later this week |
|
will be on staging for you guys to test it thoroughly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arcaea support for tachi!
marked as a draft PR until we figure out the seeds and import methods. currently waiting on arcaea 5.0 to release to get the latest seeds.