EIP1559 + EIP2718 support #6
Conversation
Integrate transaction/receipt envelop's + add tests (support 1559 payloads, 2930 payloads and legacy payloads) Integrate London block/transaction fields
|
There is some related incomplete work here that is related: https://github.com/BeamMW/eth-object and https://github.com/aurora-is-near/eth-object |
| ] | ||
| // https://eips.ethereum.org/EIPS/eip-1559 | ||
| if(rpcResult.baseFeePerGas){ | ||
| data.push(toBuffer(rpcResult.baseFeePerGas)); | ||
| } | ||
| return new this(data) |
| static get fields(){ return [ | ||
| 'chainId', | ||
| 'nonce', | ||
| 'gasPrice', | ||
| 'maxPriorityFeePerGas', | ||
| 'maxFeePerGas', | ||
| 'gasLimit', | ||
| 'to', | ||
| 'value', | ||
| 'data', | ||
| 'accessList', | ||
| 'v', | ||
| 'r', | ||
| 's', |
There was a problem hiding this comment.
there is a problem here because these new fields knock the ordering off when generating objects that dont include them
There was a problem hiding this comment.
I ran this code on proofs using eth mainnet which has a collection of legacy/version 1/version 2 transactions, it does create properly, can you give example where it would break?
| let transaction = Transaction.fromHex('0x02f8a902850df847580082cd1b947c5a0ce9267ed19b22f8cae653f198e3e8daf09880b844a9059cbb00000000000000000000000083335e0c01afac5e02ff201ba0f5979ebc4aa93f00000000000000000000000000000000000000000000000340aad21b3b70000025a087e52ad60613b36f6d6dda62ff7aef013fc91340f6511c834a28f742fcfebf34a05e1bd17543f7e875e8872a3a19386e6428b661329e1ebdd38ad3fd14c256b196') | ||
| console.log("\n\ntransaction\n", transaction) | ||
| console.log("\n\ntransaction.object\n", transaction.object) | ||
| }) |
There was a problem hiding this comment.
I dont believe the data is being encoded properly when building a new object because your test is outputting this:
transaction.object
{
chainId: '0x02',
nonce: '0x0df8475800',
maxPriorityFeePerGas: '0xcd1b',
maxFeePerGas: '0x7c5a0ce9267ed19b22f8cae653f198e3e8daf098',
gasLimit: '0x',
to: '0xa9059cbb00000000000000000000000083335e0c01afac5e02ff201ba0f5979ebc4aa93f00000000000000000000000000000000000000000000000340aad21b3b700000',
value: '0x25',
data: '0x87e52ad60613b36f6d6dda62ff7aef013fc91340f6511c834a28f742fcfebf34',
accessList: '0x5e1bd17543f7e875e8872a3a19386e6428b661329e1ebdd38ad3fd14c256b196',
v: '0x',
r: '0x',
s: '0x'
}
Look at the 'to' address. Its not the right number of digits. Some of the other data here also looks wrong
There was a problem hiding this comment.
thats odd I will look into this looks like all the fields are messed up
| 'chainId', | ||
| 'nonce', | ||
| 'gasPrice', | ||
| 'maxPriorityFeePerGas', | ||
| 'maxFeePerGas', | ||
| 'gasLimit', | ||
| 'to', | ||
| 'value', | ||
| 'data', | ||
| 'accessList', | ||
| 'v', | ||
| 'r', | ||
| 's', |
There was a problem hiding this comment.
you'll need to have some conditionals here for backwards compatibility.
There was a problem hiding this comment.
Shouldn't it only encode fields that are set in the object and skips over the ones that aren't? The proofs are valid across all the tx types.
Integrate transaction/receipt envelop's + add tests (support 1559 payloads, 2930 payloads and legacy payloads)
Integrate London block/transaction fields