Fix child node dependencies #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that child nodes are handled by edtlib there's no need to parse child nodes in check_init_priorities anymore. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
petejohanson
merged commit dacab48
into
zmkfirmware:v3.5.0+zmk-fixes
4 of 8 checks passed
urob
added a commit
to urob/zmk-config
that referenced
this pull request
Sep 3, 2025
Since zmkfirmware/zephyr#40 got merged, there is no longer a need to use a custom Zephyr.
urob
added a commit
to urob/zmk-leader-key
that referenced
this pull request
Sep 3, 2025
The child node issue was fixed in zmkfirmware/zephyr#40.
urob
added a commit
to urob/zmk-adaptive-key
that referenced
this pull request
Sep 3, 2025
The child node issue was fixed in zmkfirmware/zephyr#40.
unprolix
pushed a commit
to unprolix/zmk-config
that referenced
this pull request
Sep 13, 2025
Since zmkfirmware/zephyr#40 got merged, there is no longer a need to use a custom Zephyr. (the above is what urob said but the substance of the actual commit looked just like comments so i'm not sure what's going on)
unprolix
pushed a commit
to unprolix/zmk-config
that referenced
this pull request
Sep 21, 2025
Since zmkfirmware/zephyr#40 got merged, there is no longer a need to use a custom Zephyr. (the above is what urob said but the substance of the actual commit looked just like comments so i'm not sure what's going on)
unprolix
pushed a commit
to unprolix/zmk-config
that referenced
this pull request
Oct 8, 2025
Since zmkfirmware/zephyr#40 got merged, there is no longer a need to use a custom Zephyr.
ngutman
pushed a commit
to ngutman/zmk-config
that referenced
this pull request
Oct 31, 2025
Since zmkfirmware/zephyr#40 got merged, there is no longer a need to use a custom Zephyr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks zephyrproject-rtos@73d5ecc. The patch fixes an issue where the node dependency ordering does not take into account dependencies added by child nodes. See discord discussion for details.