Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMK Studio GA announcement #2627

Merged

Conversation

petejohanson
Copy link
Contributor

Initial work on the GA announcement of ZMK Studio. Would appreciate thoughts on things. Draft for now. Addresses zmkfirmware/zmk-studio#71

@petejohanson petejohanson self-assigned this Nov 9, 2024
Copy link
Contributor

@Nick-Munnich Nick-Munnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of links to the docs with https://zmk.dev preceeding them. I don't think that's necessary, or if it is I think docusaurus has @site or something to help with that.

docs/blog/2024-11-15-zmk-studio-mvp-ga.mdx Outdated Show resolved Hide resolved
docs/blog/2024-11-15-zmk-studio-mvp-ga.mdx Outdated Show resolved Hide resolved
docs/blog/2024-11-15-zmk-studio-mvp-ga.mdx Outdated Show resolved Hide resolved
docs/blog/2024-11-15-zmk-studio-mvp-ga.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a blocker but a better solution for static assets than checking them in would be nice to e.g. support the logos. Do the vendors provide fixed URLs, or do we not want to depend on that?

docs/blog/2024-11-15-zmk-studio-mvp-ga.mdx Outdated Show resolved Hide resolved
docs/blog/2024-11-15-zmk-studio-mvp-ga.mdx Outdated Show resolved Hide resolved
@Nick-Munnich
Copy link
Contributor

As an aside/nit, I think this comment is related

@petejohanson petejohanson force-pushed the studio/ga-release-announcement branch 6 times, most recently from 14a5add to a906fed Compare November 11, 2024 19:19
@petejohanson
Copy link
Contributor Author

It's not a blocker but a better solution for static assets than checking them in would be nice to e.g. support the logos. Do the vendors provide fixed URLs, or do we not want to depend on that?

Not consistently, and yes, the risk of some website change makes that a bit nasty. I followed @joelspadin suggestion to resize all to 76px height, and ran them through optipng.

@petejohanson petejohanson force-pushed the studio/ga-release-announcement branch 3 times, most recently from b11f058 to 1034eeb Compare November 11, 2024 19:49
@petejohanson
Copy link
Contributor Author

As an aside/nit, I think this comment is related

Yeah, I'd say that's reasonable. Reworded the first commit.

@petejohanson petejohanson marked this pull request as ready for review November 11, 2024 19:54
@petejohanson petejohanson requested a review from a team as a code owner November 11, 2024 19:54
Copy link
Contributor

@Nick-Munnich Nick-Munnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petejohanson petejohanson force-pushed the studio/ga-release-announcement branch 3 times, most recently from 199b1c6 to 7862ddb Compare November 11, 2024 23:14
petejohanson and others added 2 commits November 11, 2024 16:23
Co-authored-by: Nicolas Munnich <98408764+Nick-Munnich@users.noreply.github.com>
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
@petejohanson
Copy link
Contributor Author

There are a number of links to the docs with https://zmk.dev preceeding them. I don't think that's necessary, or if it is I think docusaurus has @site or something to help with that.

Missed this originally. Fixed.

@petejohanson petejohanson merged commit 9320271 into zmkfirmware:main Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants