-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZMK Studio GA announcement #2627
ZMK Studio GA announcement #2627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of links to the docs with https://zmk.dev
preceeding them. I don't think that's necessary, or if it is I think docusaurus has @site
or something to help with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a blocker but a better solution for static assets than checking them in would be nice to e.g. support the logos. Do the vendors provide fixed URLs, or do we not want to depend on that?
As an aside/nit, I think this comment is related |
docs/blog/assets/2024-11-15-zmk-studio-mvp-ga/cannonkeys-dark-mode.png
Outdated
Show resolved
Hide resolved
docs/blog/assets/2024-11-15-zmk-studio-mvp-ga/zmk-studio-screenshot.png
Outdated
Show resolved
Hide resolved
14a5add
to
a906fed
Compare
Not consistently, and yes, the risk of some website change makes that a bit nasty. I followed @joelspadin suggestion to resize all to 76px height, and ran them through optipng. |
b11f058
to
1034eeb
Compare
Yeah, I'd say that's reasonable. Reworded the first commit. |
1034eeb
to
3b87780
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
199b1c6
to
7862ddb
Compare
Co-authored-by: Nicolas Munnich <98408764+Nick-Munnich@users.noreply.github.com> Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
7862ddb
to
9cb784b
Compare
Missed this originally. Fixed. |
Initial work on the GA announcement of ZMK Studio. Would appreciate thoughts on things. Draft for now. Addresses zmkfirmware/zmk-studio#71