Skip to content

TOOLTIP: Adding tool tip instructions (as html-title-attr) to context menu #242 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 27, 2024
Merged

TOOLTIP: Adding tool tip instructions (as html-title-attr) to context menu #242 #244

merged 5 commits into from
Jan 27, 2024

Conversation

zmsdev
Copy link
Contributor

@zmsdev zmsdev commented Jan 26, 2024 •
edited
Loading

Added support for %meta_id.TOOLTIP and %meta_id.SORT

@zmsdev zmsdev linked an issue Jan 26, 2024 that may be closed by this pull request
TOOLTIP: Adding tool tip instructions (as html-title-attr) to context menu #242
Closed
@zmsdev zmsdev marked this pull request as draft January 26, 2024 12:01
@zmsdev zmsdev requested a review from drfho January 26, 2024 12:01
@zmsdev zmsdev self-assigned this Jan 26, 2024
@zmsdev zmsdev added the enhancement New feature or request label Jan 26, 2024
drfho
drfho reviewed Jan 27, 2024
View reviewed changes
Copy link
Contributor

@drfho drfho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLangStr() is needed to get the value:

action_menu

drfho
drfho reviewed Jan 27, 2024
View reviewed changes
Copy link
Contributor

@drfho drfho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the multiline langstr editor modal win title the textarea needs a title attribute:

action_menu2

@drfho drfho marked this pull request as ready for review January 27, 2024 14:13
drfho
drfho approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@drfho drfho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drfho drfho merged commit 7805edd into main Jan 27, 2024
drfho added a commit that referenced this pull request Jan 28, 2024
@drfho
TOOLTIP: fixed tool tip instructions in action menu
b56a4b2 
DOSIS: #244
@cmeier76 cmeier76 mentioned this pull request Mar 7, 2024
Closed
@zmsdev zmsdev deleted the 242-tooltip-adding-tool-tip-instructions-as-html-title-attr-to-context-menu branch March 19, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drfho drfho drfho approved these changes

Assignees

@zmsdev zmsdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TOOLTIP: Adding tool tip instructions (as html-title-attr) to context menu
2 participants
@zmsdev @drfho