Update unit tests for Consistency05 and Consistency06 #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
added
the
A-TestCase
matsduf
requested review from
mattias-p,
hannaeko,
a user,
tgreenx and
marc-vanderwal
matsduf
force-pushed
the
update-unit-tests-consistency05-06
branch
from
ebbab4f
to
6bf1e01
Compare
matsduf
force-pushed
the
update-unit-tests-consistency05-06
branch
from
6bf1e01
to
158202c
Compare
|
@tgreenx, can you review this and also the underlying zonemaster/zonemaster#1213? |
|
@marc-vanderwal and @tgreenx, can you review this? |
marc-vanderwal
approved these changes
Nov 27, 2023
tgreenx
approved these changes
Nov 29, 2023
| # Scenarios CHILD-ZONE-LAME-1 and IB-ADDR-MISMATCH-3 cannot be tested due to a bug in the implementation. See | ||
| # https://github.com/zonemaster/zonemaster-engine/issues/1301 | ||
| # | ||
| my %subtests = ( |
There was a problem hiding this comment.
For easier reviewing it would be best if the scenario keys in this hash were ordered in the same way as in the specification.
The same applies for file t/Test-consistency06.t below.
There was a problem hiding this comment.
I really agree. This an artefact of my script that converts a specification to a t file. I just created a Perl hash and took the order keys gave. I will update the script to get the same order as the specification.
There was a problem hiding this comment.
I will fix that afterwards.
There was a problem hiding this comment.
I will fix that in a new PR.
hannaeko
added
the
S-ReleaseTested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The PR creates unit tests based on the new test zone framework. The unit tests in this PR is based on the data in zonemaster/zonemaster#1213. It also removes old unit tests.
Due to a bug in the implementation of Constistency05 and Consistency06, respectively, some scenarios cannot presently be used. The following scenarios have not been included as unit tests due to the bug:
The bug is described in #1300 and #1301.
Changes
New unit tests are added in
t/Test-consistency05.tandt/Test-consistency06.t(plus data files).Old unit tests for Consistency05 and Consistency06 are removed, except for
t/Test-consistency05-F.tandt/Test-consistency06-B.tthat have been kept since they test for the presence ofNO_RESPONSE(with the help of "fake delegation").The
MANIFESTfile has also been updated.How to test this PR
Review zonemaster/zonemaster#1213 and verify that the CI passes.